From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 7944) id 6CDAF3858291; Fri, 12 Jan 2024 23:23:40 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 6CDAF3858291 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1705101820; bh=JVHawdd2WMYibIfucFwnYHg6eNd02joSFCUTSUaMags=; h=From:To:Subject:Date:From; b=ovYFQGz6W6s5Nk1G/ClxI1NAS14bLISXfHMJjuhwbW4wjcc6eFr0pivrJbmRTURw/ 9bsgPrUG7on68kRAwBui1hAffmg4FKnbB5nvMSIQXb1V71rXzfLVkKw7YoOwebIHXt f2I0CQIKKVb49MElmsF1w9sjm4Xl2DFsXfLkUgKA= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Pranav Kant To: glibc-cvs@sourceware.org Subject: [glibc/google/grte/v5-2.27/master] CVE-2018-19591: if_nametoindex: Fix descriptor for overlong name [BZ #23927] X-Act-Checkin: glibc X-Git-Author: Florian Weimer X-Git-Refname: refs/heads/google/grte/v5-2.27/master X-Git-Oldrev: 66bec53f073ca8ef6ac138dfe22ae9af7ce1d9db X-Git-Newrev: ac5b88042331d3a6ba0e44f8ebcc41a35ec1dab2 Message-Id: <20240112232340.6CDAF3858291@sourceware.org> Date: Fri, 12 Jan 2024 23:23:40 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=ac5b88042331d3a6ba0e44f8ebcc41a35ec1dab2 commit ac5b88042331d3a6ba0e44f8ebcc41a35ec1dab2 Author: Florian Weimer Date: Tue Nov 27 16:12:43 2018 +0100 CVE-2018-19591: if_nametoindex: Fix descriptor for overlong name [BZ #23927] Diff: --- ChangeLog | 8 ++++++++ NEWS | 4 ++++ sysdeps/unix/sysv/linux/if_index.c | 11 ++++++----- 3 files changed, 18 insertions(+), 5 deletions(-) diff --git a/ChangeLog b/ChangeLog index 7cf21922f0..0306f0caaf 100644 --- a/ChangeLog +++ b/ChangeLog @@ -31,6 +31,13 @@ * resolv/tst-resolv-nondecimal.c: Likewise. * sysdeps/posix/getaddrinfo.c (gaih_inet): Call __inet_aton_exact. +2018-11-27 Florian Weimer + + [BZ #23927] + CVE-2018-19591 + * sysdeps/unix/sysv/linux/if_index.c (__if_nametoindex): Avoid + descriptor leak in case of ENODEV error. + 2018-05-18 Joseph Myers [BZ #22639] @@ -38,6 +45,7 @@ * time/tst-y2039.c: New file. * time/Makefile (tests): Add tst-y2039. + 2018-02-12 Zack Weinberg [BZ #19239] diff --git a/NEWS b/NEWS index 162a845cc0..46b5a2d8d8 100644 --- a/NEWS +++ b/NEWS @@ -32,6 +32,10 @@ Security related changes: addresses with arbitrary trailing characters, potentially leading to data or command injection issues in applications. + CVE-2018-19591: A file descriptor leak in if_nametoindex can lead to a + denial of service due to resource exhaustion when processing getaddrinfo + calls with crafted host names. Reported by Guido Vranken. + CVE-2017-18269: An SSE2-based memmove implementation for the i386 architecture could corrupt memory. Reported by Max Horn. diff --git a/sysdeps/unix/sysv/linux/if_index.c b/sysdeps/unix/sysv/linux/if_index.c index e3d08982d9..782fc5e175 100644 --- a/sysdeps/unix/sysv/linux/if_index.c +++ b/sysdeps/unix/sysv/linux/if_index.c @@ -38,11 +38,6 @@ __if_nametoindex (const char *ifname) return 0; #else struct ifreq ifr; - int fd = __opensock (); - - if (fd < 0) - return 0; - if (strlen (ifname) >= IFNAMSIZ) { __set_errno (ENODEV); @@ -50,6 +45,12 @@ __if_nametoindex (const char *ifname) } strncpy (ifr.ifr_name, ifname, sizeof (ifr.ifr_name)); + + int fd = __opensock (); + + if (fd < 0) + return 0; + if (__ioctl (fd, SIOCGIFINDEX, &ifr) < 0) { int saved_errno = errno;