public inbox for
help / color / mirror / Atom feed
From: Adhemerval Zanella <>
Subject: [glibc] sparc: Prevent stfsr from directly following floating-point instruction
Date: Thu, 18 Jan 2024 11:47:55 +0000 (GMT)	[thread overview]
Message-ID: <> (raw);h=82a35070ec35616074343b8c4ffe6b1cff7e2793

commit 82a35070ec35616074343b8c4ffe6b1cff7e2793
Author: Daniel Cederman <>
Date:   Mon Jan 15 15:53:45 2024 +0100

    sparc: Prevent stfsr from directly following floating-point instruction
    On LEON, if the stfsr instruction is immediately following a floating-point
    operation instruction in a running program, with no other instruction in
    between the two, the stfsr might behave as if the order was reversed
    between the two instructions and the stfsr occurred before the
    floating-point operation.
    Add a nop instruction before the stfsr to prevent this from happening.
    Signed-off-by: Daniel Cederman <>
    Reviewed-by: Adhemerval Zanella  <>

 sysdeps/sparc/fpu/fpu_control.h | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/sysdeps/sparc/fpu/fpu_control.h b/sysdeps/sparc/fpu/fpu_control.h
index dd18789573..48368a7ce1 100644
--- a/sysdeps/sparc/fpu/fpu_control.h
+++ b/sysdeps/sparc/fpu/fpu_control.h
@@ -61,7 +61,12 @@ typedef unsigned long int fpu_control_t;
 # define _FPU_GETCW(cw) __asm__ __volatile__ ("stx %%fsr,%0" : "=m" (*&cw))
 # define _FPU_SETCW(cw) __asm__ __volatile__ ("ldx %0,%%fsr" : : "m" (*&cw))
-# define _FPU_GETCW(cw) __asm__ __volatile__ ("st %%fsr,%0" : "=m" (*&cw))
+# ifdef __leon__
+   /* Prevent stfsr from being placed directly after other fp instruction.  */
+#  define _FPU_GETCW(cw) __asm__ __volatile__ ("nop; st %%fsr,%0" : "=m" (*&cw))
+# else
+#  define _FPU_GETCW(cw) __asm__ __volatile__ ("st %%fsr,%0" : "=m" (*&cw))
+# endif
 # define _FPU_SETCW(cw) __asm__ __volatile__ ("ld %0,%%fsr" : : "m" (*&cw))

                 reply	other threads:[~2024-01-18 11:47 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).