From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1791) id 570CC3858012; Mon, 22 Jan 2024 13:01:20 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 570CC3858012 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1705928480; bh=VP7oI1h9H/EdOn3hrmxzHWa4EQyBkFZYt80x7WzxmTg=; h=From:To:Subject:Date:From; b=tpDYxyODYms5LG+N1u50XXAZJOlHZpMauyvtdKvbMRDKs8Z8uLbz2mbuwhChXOAI2 0QSk1+XH5IeoRY2ofVaBkRbggm6X+jfLBMsh6t43UvhnQef9KaFBqtRy8e0WE9gcSr evDRA7P14INDAIa8b1bMO6sKDZnty9yOfIvWZN58= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Adhemerval Zanella To: glibc-cvs@sourceware.org Subject: [glibc] sparc: Fix sparc64 memmove length comparison (BZ 31266) X-Act-Checkin: glibc X-Git-Author: Adhemerval Zanella X-Git-Refname: refs/heads/master X-Git-Oldrev: 369efd817780276dbe0ecf8be6e1f354bdbc9857 X-Git-Newrev: 926a4bdbb5fc8955570208b5571b2d04c6ffbd1d Message-Id: <20240122130120.570CC3858012@sourceware.org> Date: Mon, 22 Jan 2024 13:01:20 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=926a4bdbb5fc8955570208b5571b2d04c6ffbd1d commit 926a4bdbb5fc8955570208b5571b2d04c6ffbd1d Author: Adhemerval Zanella Date: Thu Jan 18 10:52:18 2024 -0300 sparc: Fix sparc64 memmove length comparison (BZ 31266) The small counts copy bytes comparsion should be unsigned (as the memmove size argument). It fixes string/tst-memmove-overflow on sparcv9, where the input size triggers an invalid code path. Checked on sparc64-linux-gnu and sparcv9-linux-gnu. Diff: --- sysdeps/sparc/sparc64/memmove.S | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sysdeps/sparc/sparc64/memmove.S b/sysdeps/sparc/sparc64/memmove.S index 8803a03d4e..f14b09afaf 100644 --- a/sysdeps/sparc/sparc64/memmove.S +++ b/sysdeps/sparc/sparc64/memmove.S @@ -38,7 +38,7 @@ ENTRY(memmove) /* * normal, copy forwards */ -2: ble %XCC, .Ldbytecp +2: bleu %XCC, .Ldbytecp andcc %o1, 3, %o5 /* is src word aligned */ bz,pn %icc, .Laldst cmp %o5, 2 /* is src half-word aligned */