From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1791) id A39E6385828B; Mon, 29 Jan 2024 17:54:56 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A39E6385828B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1706550896; bh=AyYAS+5NbOAGAcopVUg3YC9aJLWD6WE9Zzmap97ZZ9U=; h=From:To:Subject:Date:From; b=djwzwMGZz8BGSyGaFmcTuYMA3sBLelJ4eXhixIFPMaqWuy53kw1AQ6nzC4KlWUtJ2 4OpYoLK+qhlFK99M7t2PHuRNKy7hyP207pXyRC+nmbyoSL34/Mxayz3TewSOxNfN/D D4ZQ82+qgMk52EkJe4lHLziaDFW11AKvyMNv5GTQ= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Adhemerval Zanella To: glibc-cvs@sourceware.org Subject: [glibc/azanella/clang] resolv: Handle -Wsometimes-uninitialized on getaddrinfo X-Act-Checkin: glibc X-Git-Author: Adhemerval Zanella X-Git-Refname: refs/heads/azanella/clang X-Git-Oldrev: 34d0d58ef11aa95ccff3cb66760129924e492760 X-Git-Newrev: 3dc124c95c3157d51a9fe7795a327a9930d06000 Message-Id: <20240129175456.A39E6385828B@sourceware.org> Date: Mon, 29 Jan 2024 17:54:56 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=3dc124c95c3157d51a9fe7795a327a9930d06000 commit 3dc124c95c3157d51a9fe7795a327a9930d06000 Author: Adhemerval Zanella Date: Tue Mar 22 16:01:34 2022 -0300 resolv: Handle -Wsometimes-uninitialized on getaddrinfo Diff: --- nss/getaddrinfo.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/nss/getaddrinfo.c b/nss/getaddrinfo.c index 3ccd3905fa..31a0283d50 100644 --- a/nss/getaddrinfo.c +++ b/nss/getaddrinfo.c @@ -1880,6 +1880,10 @@ add_prefixlist (struct prefixlist **listp, size_t *lenp, bool *nullbitsp, if (cp != NULL) *cp++ = '\0'; *pos = cp; + /* clang warns that endp is used uninitialized whenever '||' condition + is true, however it will be evaluated after strtoul call. */ + DIAG_PUSH_NEEDS_COMMENT_CLANG; + DIAG_IGNORE_NEEDS_COMMENT_CLANG (13, "-Wsometimes-uninitialized"); if (inet_pton (AF_INET6, val1, &prefix) && (cp == NULL || (bits = strtoul (cp, &endp, 10)) != ULONG_MAX @@ -1903,6 +1907,7 @@ add_prefixlist (struct prefixlist **listp, size_t *lenp, bool *nullbitsp, ++*lenp; *nullbitsp |= bits == 0; } + DIAG_POP_NEEDS_COMMENT_CLANG; return true; } @@ -2041,6 +2046,11 @@ gaiconf_init (void) if (inet_pton (AF_INET6, val1, &prefix)) { bits = 128; + /* clang warns that endp is used uninitialized whenever '||' + condition is true, however it will be evaluated after + strtoul call. */ + DIAG_PUSH_NEEDS_COMMENT_CLANG; + DIAG_IGNORE_NEEDS_COMMENT_CLANG (13, "-Wsometimes-uninitialized"); if (IN6_IS_ADDR_V4MAPPED (&prefix) && (cp == NULL || (bits = strtoul (cp, &endp, 10)) != ULONG_MAX @@ -2062,6 +2072,7 @@ gaiconf_init (void) goto no_file; } } + DIAG_POP_NEEDS_COMMENT_CLANG; } else if (inet_pton (AF_INET, val1, &prefix.s6_addr32[3]) && (cp == NULL