From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1791) id 08D1F3858431; Mon, 29 Jan 2024 17:56:30 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 08D1F3858431 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1706550991; bh=r+HsvdVK6A5BhvXzYj9ou62jKD3QSqHt90gG6dkuAjo=; h=From:To:Subject:Date:From; b=dSc2erV41jraSfVij3M1KxEt07jlxxeb8vu1SAO6cJ/7/njVNokOeDkkcKHTdwn9y k1c/BtEvC6JulP9TPYt6d4bEnbYGmoREd+irD2JQVA9UEUSEzwQXwJDqhB/6taVIQ6 MyYpSCfRKViEEikwB1lMogSY6r6C8wlu0A0qWTsE= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Adhemerval Zanella To: glibc-cvs@sourceware.org Subject: [glibc/azanella/clang] timezone: Fix clang operator precedence warning X-Act-Checkin: glibc X-Git-Author: Adhemerval Zanella X-Git-Refname: refs/heads/azanella/clang X-Git-Oldrev: 9c94564b88a61d3ef03e14922c427ed2364c4d68 X-Git-Newrev: bee7e6dac37002da6aa254b6e6a779e5930495ff Message-Id: <20240129175631.08D1F3858431@sourceware.org> Date: Mon, 29 Jan 2024 17:56:30 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=bee7e6dac37002da6aa254b6e6a779e5930495ff commit bee7e6dac37002da6aa254b6e6a779e5930495ff Author: Adhemerval Zanella Date: Thu Mar 10 16:44:45 2022 -0300 timezone: Fix clang operator precedence warning clang issues: zdump.c:669:7: error: operator '?:' has lower precedence than '&'; '&' will be evaluated first [-Werror,-Wbitwise-conditional-parentheses] ? (delta(&tm, &lotm) == t - lot which is exactly what the code intendes. Instead of adding a warning suppress, place parentheses around the '&' expression. Diff: --- timezone/zdump.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/timezone/zdump.c b/timezone/zdump.c index b532fe3eae..bfc01faffa 100644 --- a/timezone/zdump.c +++ b/timezone/zdump.c @@ -665,7 +665,7 @@ hunt(timezone_t tz, char *name, time_t lot, time_t hit) else if (t >= hit) --t; tm_ok = my_localtime_rz(tz, &t, &tm) != NULL; - if (lotm_ok & tm_ok + if ((lotm_ok & tm_ok) ? (delta(&tm, &lotm) == t - lot && tm.tm_isdst == lotm.tm_isdst && strcmp(abbr(&tm), ab) == 0)