public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Stefan Liebler <stli@sourceware.org>
To: glibc-cvs@sourceware.org
Subject: [glibc/release/2.38/master] S390: Fix building with --disable-mutli-arch [BZ #31196]
Date: Thu,  1 Feb 2024 09:10:56 +0000 (GMT)	[thread overview]
Message-ID: <20240201091056.AB3F6385842A@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=18876c9ff52c3d9aefe2c663b1a287589bebedc0

commit 18876c9ff52c3d9aefe2c663b1a287589bebedc0
Author: Stefan Liebler <stli@linux.ibm.com>
Date:   Tue Jan 30 09:34:32 2024 +0100

    S390: Fix building with --disable-mutli-arch [BZ #31196]
    
    Starting with commits
    - 7ea510127e2067efa07865158ac92c330c379950
    string: Add libc_hidden_proto for strchrnul
    - 22999b2f0fb62eed1af4095d062bd1272d6afeb1
    string: Add libc_hidden_proto for memrchr
    
    building glibc on s390x with --disable-multi-arch fails if only
    the C-variant of strchrnul / memrchr is used.  This is the case
    if gcc uses -march < z13.
    
    The build fails with:
    ../sysdeps/s390/strchrnul-c.c:28:49: error: ‘__strchrnul_c’ undeclared here (not in a function); did you mean ‘__strchrnul’?
       28 | __hidden_ver1 (__strchrnul_c, __GI___strchrnul, __strchrnul_c);
    
    With --disable-multi-arch, __strchrnul_c is not available as string/strchrnul.c
    is just included without defining STRCHRNUL and thus we also don't have to create
    the internal hidden symbol.
    
    Tested-by: Andreas K. Hüttel <dilfridge@gentoo.org>
    (cherry picked from commit cc1b91eabd806057aa7e3058a84bf129ed36e157)

Diff:
---
 sysdeps/s390/memrchr-c.c   | 4 +++-
 sysdeps/s390/strchrnul-c.c | 4 +++-
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/sysdeps/s390/memrchr-c.c b/sysdeps/s390/memrchr-c.c
index bdf3c7bbe0..fadd63087a 100644
--- a/sysdeps/s390/memrchr-c.c
+++ b/sysdeps/s390/memrchr-c.c
@@ -25,7 +25,9 @@
 
 # include <string/memrchr.c>
 
-# if defined SHARED && IS_IN (libc)
+# if HAVE_MEMRCHR_IFUNC
+#  if defined SHARED && IS_IN (libc)
 __hidden_ver1 (__memrchr_c, __GI___memrchr, __memrchr_c);
+#  endif
 # endif
 #endif
diff --git a/sysdeps/s390/strchrnul-c.c b/sysdeps/s390/strchrnul-c.c
index f6f5bae311..97fbc16edb 100644
--- a/sysdeps/s390/strchrnul-c.c
+++ b/sysdeps/s390/strchrnul-c.c
@@ -24,7 +24,9 @@
 # endif
 
 # include <string/strchrnul.c>
-# if defined SHARED && IS_IN (libc)
+# if HAVE_STRCHRNUL_IFUNC
+#  if defined SHARED && IS_IN (libc)
 __hidden_ver1 (__strchrnul_c, __GI___strchrnul, __strchrnul_c);
+#  endif
 # endif
 #endif

                 reply	other threads:[~2024-02-01  9:10 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240201091056.AB3F6385842A@sourceware.org \
    --to=stli@sourceware.org \
    --cc=glibc-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).