From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1791) id 423963857C77; Fri, 2 Feb 2024 13:25:55 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 423963857C77 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1706880355; bh=msYUmNvGzK/QlFMnE4Lx5x8R6ca6Ci8g8tyOEuwrBLY=; h=From:To:Subject:Date:From; b=tsWKn4EOy4bWtftGACfFyoD+WMhzxMB5fYqMABtOhOzpNYstEzw8b+g8ipeuX+sqU 6QQGNHre+N+XhzPoP33LZm8sNZCRII5+eVenslnS/TvHfqZY2g0aj1oVMvIgFFCZoe ZBr3vlLTM158rfRSD94S07/0A2/RtblItQcaETEI= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Adhemerval Zanella To: glibc-cvs@sourceware.org Subject: [glibc/release/2.37/master] sparc: Fix broken memset for sparc32 [BZ #31068] X-Act-Checkin: glibc X-Git-Author: Andreas Larsson X-Git-Refname: refs/heads/release/2.37/master X-Git-Oldrev: 5bbe7e0da525679dd0a834a4970332f99f8ebb14 X-Git-Newrev: 98ec3e004e797ee7d4dc3ec43647b0cb11f3a9aa Message-Id: <20240202132555.423963857C77@sourceware.org> Date: Fri, 2 Feb 2024 13:25:55 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=98ec3e004e797ee7d4dc3ec43647b0cb11f3a9aa commit 98ec3e004e797ee7d4dc3ec43647b0cb11f3a9aa Author: Andreas Larsson Date: Wed Nov 15 13:29:43 2023 +0100 sparc: Fix broken memset for sparc32 [BZ #31068] Fixes commit a61933fe27df ("sparc: Remove bzero optimization") that after moving code jumped to the wrong label 4. Verfied by successfully running string/test-memset on sparc32. Signed-off-by: Andreas Larsson Signed-off-by: Ludwig Rydberg Reviewed-by: Adhemerval Zanella (cherry picked from commit 578190b7e43305141512dee777e4a3b3e8159393) Diff: --- sysdeps/sparc/sparc32/memset.S | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sysdeps/sparc/sparc32/memset.S b/sysdeps/sparc/sparc32/memset.S index ca29ff5685..1dc3a640e8 100644 --- a/sysdeps/sparc/sparc32/memset.S +++ b/sysdeps/sparc/sparc32/memset.S @@ -55,7 +55,7 @@ ENTRY(memset) andcc %o0, 3, %o2 bne 3f -4: andcc %o0, 4, %g0 +5: andcc %o0, 4, %g0 be 2f mov %g3, %g2 @@ -139,7 +139,7 @@ ENTRY(memset) stb %g3, [%o0 + 0x02] 2: sub %o2, 4, %o2 add %o1, %o2, %o1 - b 4b + b 5b sub %o0, %o2, %o0 END(memset) libc_hidden_builtin_def (memset)