From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1791) id 9357D3857C40; Fri, 2 Feb 2024 13:26:05 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9357D3857C40 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1706880365; bh=JVEmaZa1xXs3//x3ws3mxNBqGEh4xmr/z+mwljNnih0=; h=From:To:Subject:Date:From; b=Wb9DWjlylv9SIZv66FsFeHzBvRksTGbdbD1cScjXNJB4PGZwBUZ089hn8Cr07q4mq qryk4hpvfYC5clo+VleBFSpzFLzor5W9SdPJkbBcprWCuC2ECy4f2D+39bozbVP7nY VXRTNhVzeOxddHF4s1B+uwpN6+yW9jq/GL5jIDug= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Adhemerval Zanella To: glibc-cvs@sourceware.org Subject: [glibc/release/2.37/master] sparc: Fix sparc64 memmove length comparison (BZ 31266) X-Act-Checkin: glibc X-Git-Author: Adhemerval Zanella X-Git-Refname: refs/heads/release/2.37/master X-Git-Oldrev: 2ce7abef6767e41c32f6271eece7b5d13c4d6eb5 X-Git-Newrev: 18da90677cc412d524a00af6f5242236a5ab1cb6 Message-Id: <20240202132605.9357D3857C40@sourceware.org> Date: Fri, 2 Feb 2024 13:26:05 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=18da90677cc412d524a00af6f5242236a5ab1cb6 commit 18da90677cc412d524a00af6f5242236a5ab1cb6 Author: Adhemerval Zanella Date: Thu Jan 18 10:52:18 2024 -0300 sparc: Fix sparc64 memmove length comparison (BZ 31266) The small counts copy bytes comparsion should be unsigned (as the memmove size argument). It fixes string/tst-memmove-overflow on sparcv9, where the input size triggers an invalid code path. Checked on sparc64-linux-gnu and sparcv9-linux-gnu. (cherry picked from commit 926a4bdbb5fc8955570208b5571b2d04c6ffbd1d) Diff: --- sysdeps/sparc/sparc64/memmove.S | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sysdeps/sparc/sparc64/memmove.S b/sysdeps/sparc/sparc64/memmove.S index e38343a702..7e9a963e77 100644 --- a/sysdeps/sparc/sparc64/memmove.S +++ b/sysdeps/sparc/sparc64/memmove.S @@ -38,7 +38,7 @@ ENTRY(memmove) /* * normal, copy forwards */ -2: ble %XCC, .Ldbytecp +2: bleu %XCC, .Ldbytecp andcc %o1, 3, %o5 /* is src word aligned */ bz,pn %icc, .Laldst cmp %o5, 2 /* is src half-word aligned */