From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1791) id 065FD3858417; Wed, 7 Feb 2024 14:05:56 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 065FD3858417 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1707314757; bh=sOdF4NftEZtxvUmv3FtNjISHRZFMaC4rfY0t3xQCKfk=; h=From:To:Subject:Date:From; b=ZrgIA6+qaV0sZ7cPlkZhAZEdgy3NrtTuZvd7ebtjAojxPFyctzyIhkoKpZKYBTagM MUfjZNH9K6wAm8zeB0pVfQS1EowB8DpipQyu1yU/gFuN7chNELa5RsH6v13wx4SrBZ 7Wq5QKYr82E7wc+1L5XfD8OPufgc1tYXW3Lb8u2E= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Adhemerval Zanella To: glibc-cvs@sourceware.org Subject: [glibc/azanella/clang] math: Suppress clang warning on math_check_force_underflow X-Act-Checkin: glibc X-Git-Author: Adhemerval Zanella X-Git-Refname: refs/heads/azanella/clang X-Git-Oldrev: 688de9ea21eac0e014fdb07ea23866081c56d6c8 X-Git-Newrev: b1ab64f0fbbdb6df4ddc83147ba17709f8b76c01 Message-Id: <20240207140557.065FD3858417@sourceware.org> Date: Wed, 7 Feb 2024 14:05:56 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=b1ab64f0fbbdb6df4ddc83147ba17709f8b76c01 commit b1ab64f0fbbdb6df4ddc83147ba17709f8b76c01 Author: Adhemerval Zanella Date: Thu Mar 10 13:53:13 2022 -0300 math: Suppress clang warning on math_check_force_underflow Clang warns: ../sysdeps/x86/fpu/powl_helper.c:233:3: error: absolute value function '__builtin_fabsf' given an argument of type 'typeof (res)' (aka 'long double') but has parameter of type 'float' which may cause truncation of value [-Werror,-Wabsolute-value] math_check_force_underflow (res); ^ ./math-underflow.h:45:11: note: expanded from macro 'math_check_force_underflow' if (fabs_tg (force_underflow_tmp) \ ^ ./math-underflow.h:27:20: note: expanded from macro 'fabs_tg' #define fabs_tg(x) __MATH_TG ((x), (__typeof (x)) __builtin_fabs, (x)) ^ ../math/math.h:899:16: note: expanded from macro '__MATH_TG' float: FUNC ## f ARGS, \ ^ :73:1: note: expanded from here __builtin_fabsf ^ Diff: --- math/math-underflow.h | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/math/math-underflow.h b/math/math-underflow.h index 5539a0a6e7..b39637c2bd 100644 --- a/math/math-underflow.h +++ b/math/math-underflow.h @@ -23,6 +23,7 @@ #include #include +#include #define fabs_tg(x) __MATH_TG ((x), (__typeof (x)) __builtin_fabs, (x)) @@ -37,10 +38,15 @@ #define min_of_type(x) __MATH_TG ((x), (__typeof (x)) min_of_type_, ()) /* If X (which is not a NaN) is subnormal, force an underflow - exception. */ + exception. + + clang issues a warning where _Generic is using a non expected + builtin which may cause truncation of value. */ #define math_check_force_underflow(x) \ do \ { \ + DIAG_PUSH_NEEDS_COMMENT_CLANG; \ + DIAG_IGNORE_NEEDS_COMMENT_CLANG (13, "-Wabsolute-value"); \ __typeof (x) force_underflow_tmp = (x); \ if (fabs_tg (force_underflow_tmp) \ < min_of_type (force_underflow_tmp)) \ @@ -49,6 +55,7 @@ = force_underflow_tmp * force_underflow_tmp; \ math_force_eval (force_underflow_tmp2); \ } \ + DIAG_POP_NEEDS_COMMENT_CLANG; \ } \ while (0) /* Likewise, but X is also known to be nonnegative. */