public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Adhemerval Zanella <azanella@sourceware.org>
To: glibc-cvs@sourceware.org
Subject: [glibc/azanella/clang] localedata: Fix clang warnings on tests
Date: Wed,  7 Feb 2024 14:08:26 +0000 (GMT)	[thread overview]
Message-ID: <20240207140826.5DB403858434@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=ec60dc474e039250be1ee16323442df90b3bd1b8

commit ec60dc474e039250be1ee16323442df90b3bd1b8
Author: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Date:   Tue Mar 15 15:29:47 2022 -0300

    localedata: Fix clang warnings on tests
    
    clang does not support 'I' specifier and handles it as a 'length
    modifier'.

Diff:
---
 localedata/tst-trans.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/localedata/tst-trans.c b/localedata/tst-trans.c
index 2819bb32cc..3c0db4d5c1 100644
--- a/localedata/tst-trans.c
+++ b/localedata/tst-trans.c
@@ -22,6 +22,7 @@
 #include <string.h>
 #include <wchar.h>
 #include <wctype.h>
+#include <libc-diag.h>
 
 static int
 do_test (void)
@@ -59,7 +60,12 @@ do_test (void)
   errors |= len != 10;
   printf ("len = %d, wbuf = L\"%ls\"\n", len, wbuf);
 
-  snprintf (buf, sizeof buf, "%Id", 0x499602D2);
+  /* clang does not support 'I' specifier and handles it as a 'length
+   * modifier'.  */
+  DIAG_PUSH_NEEDS_COMMENT_CLANG;
+  DIAG_IGNORE_NEEDS_COMMENT_CLANG (16, "-Wformat");
+  snprintf (buf, sizeof buf, "%Id", 0x499602D2U);
+  DIAG_POP_NEEDS_COMMENT_CLANG;
   errors |= strcmp (buf, "bcdefghija") != 0;
   len = strlen (buf);
   errors |= len != 10;

             reply	other threads:[~2024-02-07 14:08 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-07 14:08 Adhemerval Zanella [this message]
  -- strict thread matches above, loose matches on Subject: below --
2024-04-17 20:08 Adhemerval Zanella
2024-04-02 15:54 Adhemerval Zanella
2024-02-09 17:33 Adhemerval Zanella
2024-01-29 17:58 Adhemerval Zanella
2023-12-21 18:55 Adhemerval Zanella
2023-09-28 17:53 Adhemerval Zanella
2023-08-30 12:37 Adhemerval Zanella
2023-02-09 19:49 Adhemerval Zanella
2022-10-28 17:42 Adhemerval Zanella
2022-10-04 13:00 Adhemerval Zanella
2022-06-09 21:21 Adhemerval Zanella
2022-06-09 13:17 Adhemerval Zanella
2022-06-03 14:07 Adhemerval Zanella
2022-05-13 14:21 Adhemerval Zanella
2022-05-12 19:34 Adhemerval Zanella
2022-05-10 18:25 Adhemerval Zanella
2022-04-29 14:05 Adhemerval Zanella
2022-04-04 12:55 Adhemerval Zanella
2022-03-31 19:07 Adhemerval Zanella
2022-03-29 20:31 Adhemerval Zanella
2022-03-16 18:05 Adhemerval Zanella

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240207140826.5DB403858434@sourceware.org \
    --to=azanella@sourceware.org \
    --cc=glibc-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).