From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1791) id 4B5AE385829A; Wed, 7 Feb 2024 14:10:19 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4B5AE385829A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1707315019; bh=luZyHFeneqHGB0P135ItcRKcMGdCQYEodmBBM31ILyw=; h=From:To:Subject:Date:From; b=Z0tuwLP3Ac38WISwL0Wfmt22znYfO0+L3dJNwot+l0KekluVJGS8S8WqhQ02CkjOv DQY+RMR1hOYlPLJTf9mVn01oNOI8HK6RttjaWR/v9ErF/qx8uTWkMgnjGcFIs3JET4 lLTxve/ulI0jU0lmlM02N5Wty/siMaqZlPNCa5vk= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Adhemerval Zanella To: glibc-cvs@sourceware.org Subject: [glibc/azanella/clang] dirent: Remove variable lenght array structure for tst-getdents64.c X-Act-Checkin: glibc X-Git-Author: Adhemerval Zanella X-Git-Refname: refs/heads/azanella/clang X-Git-Oldrev: ae73abe4a13c75b6ac66de996b67fc9e608ca317 X-Git-Newrev: 56cd19161315921f3a35768b7116dd4a2aab62f1 Message-Id: <20240207141019.4B5AE385829A@sourceware.org> Date: Wed, 7 Feb 2024 14:10:19 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=56cd19161315921f3a35768b7116dd4a2aab62f1 commit 56cd19161315921f3a35768b7116dd4a2aab62f1 Author: Adhemerval Zanella Date: Fri Mar 25 09:03:03 2022 -0300 dirent: Remove variable lenght array structure for tst-getdents64.c Clang emits the following warnings: ../sysdeps/unix/sysv/linux/tst-getdents64.c:111:18: error: fields must have a constant size: 'variable length array in structure' extension will never be supported char buffer[buffer_size]; ^ Diff: --- sysdeps/unix/sysv/linux/tst-getdents64.c | 16 +++++----------- 1 file changed, 5 insertions(+), 11 deletions(-) diff --git a/sysdeps/unix/sysv/linux/tst-getdents64.c b/sysdeps/unix/sysv/linux/tst-getdents64.c index 3dd22a4e03..458627bac1 100644 --- a/sysdeps/unix/sysv/linux/tst-getdents64.c +++ b/sysdeps/unix/sysv/linux/tst-getdents64.c @@ -96,6 +96,8 @@ do_test_by_size (size_t buffer_size) int fd = xopen (".", O_RDONLY | O_DIRECTORY, 0); TEST_VERIFY (fd >= 0); + char *data = xposix_memalign (_Alignof (struct dirent64), buffer_size); + /* Perform two passes, with a rewind operating between passes. */ for (int pass = 0; pass < 2; ++pass) { @@ -104,23 +106,15 @@ do_test_by_size (size_t buffer_size) while (true) { - /* Simple way to make sure that the memcpy below does not read - non-existing data. */ - struct - { - char buffer[buffer_size]; - struct dirent64 pad; - } data; - - ssize_t ret = getdents64 (fd, &data.buffer, sizeof (data.buffer)); + ssize_t ret = getdents64 (fd, data, buffer_size); if (ret < 0) FAIL_EXIT1 ("getdents64: %m"); if (ret == 0) break; ++read_count; - char *current = data.buffer; - char *end = data.buffer + ret; + char *current = data; + char *end = data + ret; while (current != end) { struct dirent64 entry;