From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1791) id E795A385829B; Wed, 7 Feb 2024 14:14:45 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E795A385829B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1707315285; bh=0lNWdr/Sz5ha7KDBY8nz23s93ITtw3S6Uq95QgM0uIM=; h=From:To:Subject:Date:From; b=vkRkY2Idc6TOrInKSTHB2KdZPS+s5FYC5uyAZpGn2j4LY8Y+FdfuaRLn9S1bYiGoT Pfz+bgxEs4HV8iE4LkCpDuBZfwDc/FpWkGv7Lg45fBb8gz0+5xYUmllIMOTxat8qKK X3uEt7wSymsiF8uVuc1JC+XO8PTIDnTRgulfxl58= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Adhemerval Zanella To: glibc-cvs@sourceware.org Subject: [glibc/azanella/clang] benchtests: Add attribute_optimize X-Act-Checkin: glibc X-Git-Author: Adhemerval Zanella X-Git-Refname: refs/heads/azanella/clang X-Git-Oldrev: 1c101ff9501d378360d29e41bbfa8caaf046bb5e X-Git-Newrev: 218c3d999f55aa0149104a44444834a68dfbe546 Message-Id: <20240207141445.E795A385829B@sourceware.org> Date: Wed, 7 Feb 2024 14:14:45 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=218c3d999f55aa0149104a44444834a68dfbe546 commit 218c3d999f55aa0149104a44444834a68dfbe546 Author: Adhemerval Zanella Date: Tue Feb 6 16:51:25 2024 -0300 benchtests: Add attribute_optimize Similar to tst-printf-bz18872.sh, add the attribute_optimize to avoid build failures with compilers that do not support "GCC optimize" pragma. Diff: --- benchtests/bench-pthread-lock-base.c | 11 +++++------ benchtests/bench-pthread-locks.c | 10 +++------- benchtests/bench-util.h | 6 ++++++ 3 files changed, 14 insertions(+), 13 deletions(-) diff --git a/benchtests/bench-pthread-lock-base.c b/benchtests/bench-pthread-lock-base.c index 0a6155714a..e94a69321c 100644 --- a/benchtests/bench-pthread-lock-base.c +++ b/benchtests/bench-pthread-lock-base.c @@ -28,6 +28,7 @@ #include #include #include "bench-timing.h" +#include "bench-util.h" #include "json-lib.h" static bench_lock_t lock; @@ -36,10 +37,8 @@ static pthread_barrier_t barrier; #define START_ITERS 1000 -#pragma GCC push_options -#pragma GCC optimize(1) - -static int __attribute__ ((noinline)) fibonacci (int i) +static int __attribute__ ((noinline)) attribute_optimize (1) +fibonacci (int i) { asm(""); if (i > 2) @@ -48,6 +47,7 @@ static int __attribute__ ((noinline)) fibonacci (int i) } static void +attribute_optimize (1) do_filler (void) { char buf1[512], buf2[512]; @@ -56,6 +56,7 @@ do_filler (void) } static void +attribute_optimize (1) do_filler_shared (void) { static char buf1[512], buf2[512]; @@ -63,8 +64,6 @@ do_filler_shared (void) memcpy (buf1, buf2, f); } -#pragma GCC pop_options - #define UNIT_WORK_CRT do_filler_shared () #define UNIT_WORK_NON_CRT do_filler () diff --git a/benchtests/bench-pthread-locks.c b/benchtests/bench-pthread-locks.c index 9cfe08604a..c7e82d1d81 100644 --- a/benchtests/bench-pthread-locks.c +++ b/benchtests/bench-pthread-locks.c @@ -29,6 +29,7 @@ #include #include #include "bench-timing.h" +#include "bench-util.h" #include "json-lib.h" /* The point of this benchmark is to measure the overhead of an empty @@ -61,10 +62,7 @@ typedef timing_t (*test_t)(long, int); total time each test iteration takes, so as to not swamp the useful timings. */ -#pragma GCC push_options -#pragma GCC optimize(1) - -static int __attribute__((noinline)) +static int __attribute__((noinline)) attribute_optimize (1) fibonacci (int i) { asm(""); @@ -73,7 +71,7 @@ fibonacci (int i) return 10+i; } -static void +static void attribute_optimize (1) do_filler (void) { static char buf1[512], buf2[512]; @@ -81,8 +79,6 @@ do_filler (void) memcpy (buf1, buf2, f); } -#pragma GCC pop_options - static timing_t test_mutex (long iters, int filler) { diff --git a/benchtests/bench-util.h b/benchtests/bench-util.h index 91d9089237..66a677ac9b 100644 --- a/benchtests/bench-util.h +++ b/benchtests/bench-util.h @@ -24,6 +24,12 @@ __v; \ }) +#if __GNUC_PREREQ (4, 4) || __glibc_has_attribute (__optimize__) +# define attribute_optimize(level) __attribute__ ((optimize (level))) +#else +# define attribute_optimize(level) +#endif + #ifndef START_ITER # define START_ITER (100000000) #endif