From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2178) id 928763858403; Fri, 9 Feb 2024 15:16:56 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 928763858403 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1707491816; bh=/n4RZB/kVUYXaD6iFdl3qZ2EJD4QIbV01EzFM8FUZSw=; h=From:To:Subject:Date:From; b=jxyjLreJ3dbRVrKhevJV0+gou8cZw4dtvM5OWw5uMCnow/u13OKwbrlDuDWUiSAsW hpQ/8SH/I6UrfkTEBxBWQWJbkJL05QkZfnvu74Xd6U4ayFJBdQqCZa+UnflA+bfeeP xgBaMb2PmHN0PpGUu5gAqfM/1fUqZsmda4RuBLQU= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Florian Weimer To: glibc-cvs@sourceware.org Subject: [glibc] elf: Remove attempt at env handling in elf/tst-rtld-list-diagnostics.py X-Act-Checkin: glibc X-Git-Author: Florian Weimer X-Git-Refname: refs/heads/master X-Git-Oldrev: 1bc61cf8e074e9faf67e6d32e99cb8ddab7e2eb6 X-Git-Newrev: 15de3d17e1d9da5d38efb0a87a82efbc5bda732d Message-Id: <20240209151656.928763858403@sourceware.org> Date: Fri, 9 Feb 2024 15:16:56 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=15de3d17e1d9da5d38efb0a87a82efbc5bda732d commit 15de3d17e1d9da5d38efb0a87a82efbc5bda732d Author: Florian Weimer Date: Fri Feb 9 16:16:08 2024 +0100 elf: Remove attempt at env handling in elf/tst-rtld-list-diagnostics.py Instead, let the system shell parse the whole thing and invoke the env command. Diff: --- elf/tst-rtld-list-diagnostics.py | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/elf/tst-rtld-list-diagnostics.py b/elf/tst-rtld-list-diagnostics.py index 9e70e74bf8..024bd8c320 100644 --- a/elf/tst-rtld-list-diagnostics.py +++ b/elf/tst-rtld-list-diagnostics.py @@ -222,7 +222,7 @@ else: def parse_diagnostics(cmd): global errors diag_out = subprocess.run(cmd, stdout=subprocess.PIPE, check=True, - universal_newlines=True).stdout + universal_newlines=True, shell=True).stdout if diag_out[-1] != '\n': print('error: ld.so output does not end in newline') errors += 1 @@ -293,8 +293,7 @@ def main(argv): if opts.manual: check_consistency_with_manual(opts.manual) - # Remove the initial 'env' command. - parse_diagnostics(opts.command.split()[1:]) + parse_diagnostics(opts.command) if errors: sys.exit(1)