From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1791) id 834AC385841F; Fri, 9 Feb 2024 17:28:52 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 834AC385841F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1707499732; bh=coHHdtYBecOqnCumXNR1dLuz9crDJNTGRPAvQJGEAfc=; h=From:To:Subject:Date:From; b=lIRtwCs5dn0g2XcUweTLhZZzWIAwe+Mbuwkm+s0Z0kPxNuyG+/OHzJjeFcLyB4nLv fLlo6xIKtQlIJZHrhBtV7AHwmavGpv34sC5qY9tYrr4K0ygnMppz+pFB4XI79swwXo p1GZPbXD3m7ZGxJxgEyXI2eXHzDaZk3sEK8YRQx4= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Adhemerval Zanella To: glibc-cvs@sourceware.org Subject: [glibc/azanella/clang] Disable __USE_EXTERN_INLINES for clang X-Act-Checkin: glibc X-Git-Author: Adhemerval Zanella X-Git-Refname: refs/heads/azanella/clang X-Git-Oldrev: 5a30a64e0b2d35712f35821b8f23f0f38308ef07 X-Git-Newrev: 5a5018165fc28e4689643d74ceae66288c997be4 Message-Id: <20240209172852.834AC385841F@sourceware.org> Date: Fri, 9 Feb 2024 17:28:52 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=5a5018165fc28e4689643d74ceae66288c997be4 commit 5a5018165fc28e4689643d74ceae66288c997be4 Author: Adhemerval Zanella Date: Thu Oct 7 18:16:04 2021 -0700 Disable __USE_EXTERN_INLINES for clang clang does not allow to redefine attributes after function declaration. Although it work for external usage, its breaks the build for internal symbol that glibc provides as optimization (for instance bsearch with stdlib-bsearch.h or __cmsg_nxthdr). Disable such optimization for clang while building glibc. Diff: --- include/features.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/features.h b/include/features.h index d92503dfed..23e29b9f4d 100644 --- a/include/features.h +++ b/include/features.h @@ -523,7 +523,7 @@ /* Decide whether we can define 'extern inline' functions in headers. */ #if __GNUC_PREREQ (2, 7) && defined __OPTIMIZE__ \ && !defined __OPTIMIZE_SIZE__ && !defined __NO_INLINE__ \ - && defined __extern_inline + && defined __extern_inline && !(defined __clang__ && defined _LIBC) # define __USE_EXTERN_INLINES 1 #endif