public inbox for glibc-cvs@sourceware.org help / color / mirror / Atom feed
From: Adhemerval Zanella <azanella@sourceware.org> To: glibc-cvs@sourceware.org Subject: [glibc/azanella/clang] math: Fix clang warnings on bug-tgmath1.c Date: Fri, 9 Feb 2024 17:33:17 +0000 (GMT) [thread overview] Message-ID: <20240209173317.6CE813858416@sourceware.org> (raw) https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=8135781ced0959951eacde8d5ab184fafb46ca6a commit 8135781ced0959951eacde8d5ab184fafb46ca6a Author: Adhemerval Zanella <adhemerval.zanella@linaro.org> Date: Thu Mar 24 11:08:44 2022 -0300 math: Fix clang warnings on bug-tgmath1.c The type generic fabs expansion issues the floating point absolute with the wrong argument type (for instance cabs with floating point or fabs with a complex type) and clang warns that implicit conversion might incur in unexpected behavior. Diff: --- math/bug-tgmath1.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/math/bug-tgmath1.c b/math/bug-tgmath1.c index 16db9d17a1..1c97df0a40 100644 --- a/math/bug-tgmath1.c +++ b/math/bug-tgmath1.c @@ -1,5 +1,6 @@ #include <stdio.h> #include <tgmath.h> +#include <libc-diag.h> int @@ -29,6 +30,12 @@ main (void) TEST (cimag (1.0f), sizeof (float)); TEST (cimag (1.0f + 1.0fi), sizeof (float)); + /* The type generic fabs expansion issues the floating point absolute with + the wrong argument type (for instance cabs with floating point or fabs + with a complex type) and clang warns that implicit conversion might + incur in unexpected behavior. */ + DIAG_PUSH_NEEDS_COMMENT_CLANG; + DIAG_IGNORE_NEEDS_COMMENT_CLANG (13, "-Wabsolute-value"); TEST (fabs (1.0), sizeof (double)); TEST (fabs (1.0 + 1.0i), sizeof (double)); TEST (fabs (1.0l), sizeof (long double));
next reply other threads:[~2024-02-09 17:33 UTC|newest] Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-02-09 17:33 Adhemerval Zanella [this message] -- strict thread matches above, loose matches on Subject: below -- 2024-04-17 20:08 Adhemerval Zanella 2024-04-02 15:54 Adhemerval Zanella 2024-02-07 14:08 Adhemerval Zanella 2024-01-29 17:58 Adhemerval Zanella 2023-12-21 18:55 Adhemerval Zanella 2023-09-28 17:53 Adhemerval Zanella 2023-08-30 12:37 Adhemerval Zanella 2023-02-09 19:49 Adhemerval Zanella 2022-10-28 17:43 Adhemerval Zanella 2022-10-04 13:00 Adhemerval Zanella 2022-06-09 21:21 Adhemerval Zanella 2022-06-09 13:18 Adhemerval Zanella 2022-06-03 14:07 Adhemerval Zanella 2022-05-13 14:21 Adhemerval Zanella 2022-05-12 19:35 Adhemerval Zanella 2022-05-10 18:25 Adhemerval Zanella 2022-04-29 14:05 Adhemerval Zanella 2022-04-04 12:55 Adhemerval Zanella 2022-03-31 19:08 Adhemerval Zanella 2022-03-29 20:31 Adhemerval Zanella
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20240209173317.6CE813858416@sourceware.org \ --to=azanella@sourceware.org \ --cc=glibc-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).