public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Adhemerval Zanella <azanella@sourceware.org>
To: glibc-cvs@sourceware.org
Subject: [glibc/azanella/clang] elf: Fix tests that require interposable symbols
Date: Fri,  9 Feb 2024 17:39:02 +0000 (GMT)	[thread overview]
Message-ID: <20240209173902.2386F385840F@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=59c270c3e59a859ced1204d2be03510539a32925

commit 59c270c3e59a859ced1204d2be03510539a32925
Author: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Date:   Wed Jan 17 15:21:25 2024 -0300

    elf: Fix tests that require interposable symbols
    
    clang defaults to -fsemantic-interposition, which in turn trigger some
    optimizations (like inline) that makes some tests that rely on ELF
    symbol interposition to fail.  For this case, explicit set the symbol as
    weak to avoid it.

Diff:
---
 elf/tst-dlclose-lazy-mod2.c | 1 +
 elf/tst-piemod1.c           | 1 +
 2 files changed, 2 insertions(+)

diff --git a/elf/tst-dlclose-lazy-mod2.c b/elf/tst-dlclose-lazy-mod2.c
index d1ae34330c..544803ca3e 100644
--- a/elf/tst-dlclose-lazy-mod2.c
+++ b/elf/tst-dlclose-lazy-mod2.c
@@ -20,6 +20,7 @@
 #include <stdlib.h>
 
 void
+__attribute__ ((weak))
 exported_function (int ignored)
 {
   /* This function is interposed from tst-dlclose-lazy-mod1.so and
diff --git a/elf/tst-piemod1.c b/elf/tst-piemod1.c
index 72d7e0a187..225c057ea3 100644
--- a/elf/tst-piemod1.c
+++ b/elf/tst-piemod1.c
@@ -1,6 +1,7 @@
 #include <stdio.h>
 
 int
+__attribute__((weak))
 foo (void)
 {
   return 21;

             reply	other threads:[~2024-02-09 17:39 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-09 17:39 Adhemerval Zanella [this message]
  -- strict thread matches above, loose matches on Subject: below --
2024-04-17 20:14 Adhemerval Zanella
2024-04-02 16:00 Adhemerval Zanella
2024-02-07 14:14 Adhemerval Zanella
2024-01-29 18:04 Adhemerval Zanella

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240209173902.2386F385840F@sourceware.org \
    --to=azanella@sourceware.org \
    --cc=glibc-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).