public inbox for glibc-cvs@sourceware.org help / color / mirror / Atom feed
From: Adhemerval Zanella <azanella@sourceware.org> To: glibc-cvs@sourceware.org Subject: [glibc/azanella/clang] benchtests: Remove clang warnings Date: Fri, 9 Feb 2024 17:39:43 +0000 (GMT) [thread overview] Message-ID: <20240209173943.112F03858407@sourceware.org> (raw) https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=79a99d11da2083e551ae6fc28f692d08344069c6 commit 79a99d11da2083e551ae6fc28f692d08344069c6 Author: Adhemerval Zanella <adhemerval.zanella@linaro.org> Date: Tue Feb 6 16:52:17 2024 -0300 benchtests: Remove clang warnings clangs warns of the implicit cast of RAND_MAX to float: error: implicit conversion from 'int' to 'float' changes value from 2147483647 to 2147483648 [-Werror,-Wimplicit-const-int-float-conversion] So make it explicit. Diff: --- benchtests/bench-malloc-thread.c | 2 +- benchtests/bench-strchr.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/benchtests/bench-malloc-thread.c b/benchtests/bench-malloc-thread.c index 46fdabd30c..74e71ec9ce 100644 --- a/benchtests/bench-malloc-thread.c +++ b/benchtests/bench-malloc-thread.c @@ -63,7 +63,7 @@ get_block_size (unsigned int rand_data) float min_pow = powf (dist_min, exponent + 1); float max_pow = powf (dist_max, exponent + 1); - float r = (float) rand_data / RAND_MAX; + float r = (float) rand_data / (float) RAND_MAX; return (unsigned int) powf ((max_pow - min_pow) * r + min_pow, 1 / (exponent + 1)); diff --git a/benchtests/bench-strchr.c b/benchtests/bench-strchr.c index 5ef3a9d438..35e674fed0 100644 --- a/benchtests/bench-strchr.c +++ b/benchtests/bench-strchr.c @@ -97,7 +97,7 @@ do_one_rand_plus_branch_test (json_ctx_t *json_ctx, impl_t *impl, const CHAR *s, const CHAR *c) { size_t i, iters = INNER_LOOP_ITERS8; - int must_execute = 0; + volatile int must_execute = 0; timing_t start, stop, cur; TIMING_NOW (start); for (i = 0; i < iters; ++i) @@ -162,7 +162,7 @@ do_rand_test (json_ctx_t *json_ctx, size_t align, size_t pos, size_t len, buf[align + len] = 0; buf[align + pos] = 1; - perc_zero_int = perc_zero * RAND_MAX; + perc_zero_int = perc_zero * (float) RAND_MAX; for (i = 0; i < NUM_SEARCH_CHARS; ++i) { if (rand () > perc_zero_int)
next reply other threads:[~2024-02-09 17:39 UTC|newest] Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-02-09 17:39 Adhemerval Zanella [this message] -- strict thread matches above, loose matches on Subject: below -- 2024-04-17 20:15 Adhemerval Zanella 2024-04-02 16:01 Adhemerval Zanella 2024-02-07 14:14 Adhemerval Zanella
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20240209173943.112F03858407@sourceware.org \ --to=azanella@sourceware.org \ --cc=glibc-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).