From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2178) id E264B3858408; Fri, 16 Feb 2024 06:41:27 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E264B3858408 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1708065687; bh=+x77bao8ZNbjIY2ZThaPUWk/SrORhv7FhlZCBSjggcc=; h=From:To:Subject:Date:From; b=m/bkKt0zUiqzWGkrr60R2pMeKE7jXuT2B9+gyNMoiFxNjUKptVNNiOp9eefbTgAJ6 qF2V0+4a/m3NjeV7RZyWIv2rYzvjWbanwfHjuoufR+d11z1XAaqdq7qiuXq8fprJ6T 6pi5oiehPxIJKnXGCKU9A9IcLvsdVspR56N26NIw= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Florian Weimer To: glibc-cvs@sourceware.org Subject: [glibc] i386: Use generic memrchr in libc (bug 31316) X-Act-Checkin: glibc X-Git-Author: Florian Weimer X-Git-Refname: refs/heads/master X-Git-Oldrev: ef7f4b1fef67430a8f3cfc77fa6aada2add851d7 X-Git-Newrev: 0d9166c2245cad4ac520b337dee40c9a583872b6 Message-Id: <20240216064127.E264B3858408@sourceware.org> Date: Fri, 16 Feb 2024 06:41:27 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=0d9166c2245cad4ac520b337dee40c9a583872b6 commit 0d9166c2245cad4ac520b337dee40c9a583872b6 Author: Florian Weimer Date: Fri Feb 16 07:40:37 2024 +0100 i386: Use generic memrchr in libc (bug 31316) Before this change, we incorrectly used the SSE2 variant in the implementation, without checking that the system actually supports SSE2. Tested-by: Sam James Diff: --- sysdeps/i386/i686/multiarch/memrchr-c.c | 1 + sysdeps/i386/i686/multiarch/memrchr-sse2.S | 1 - 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/sysdeps/i386/i686/multiarch/memrchr-c.c b/sysdeps/i386/i686/multiarch/memrchr-c.c index ef7bbbe792..20bfdf3af3 100644 --- a/sysdeps/i386/i686/multiarch/memrchr-c.c +++ b/sysdeps/i386/i686/multiarch/memrchr-c.c @@ -5,3 +5,4 @@ extern void *__memrchr_ia32 (const void *, int, size_t); #endif #include "string/memrchr.c" +strong_alias (__memrchr_ia32, __GI___memrchr) diff --git a/sysdeps/i386/i686/multiarch/memrchr-sse2.S b/sysdeps/i386/i686/multiarch/memrchr-sse2.S index d9dae04171..e123f87435 100644 --- a/sysdeps/i386/i686/multiarch/memrchr-sse2.S +++ b/sysdeps/i386/i686/multiarch/memrchr-sse2.S @@ -720,5 +720,4 @@ L(ret_null): ret END (__memrchr_sse2) -strong_alias (__memrchr_sse2, __GI___memrchr) #endif