From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1792) id 0D78F3858D38; Sat, 23 Mar 2024 22:16:41 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0D78F3858D38 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1711232202; bh=6HAw53e0zDJ23/DyzTrYJ68LuFsokJOnQ7XFXInKUeM=; h=From:To:Subject:Date:From; b=p/YOm7ca8x+1uLO6tLoNOBk6ORB8TpnM7jhqYaf1nwJiz4F43KFFyzhcGHTgXgUdW Q97Xp6Xsr4fY1GX1mrYOljSRWwJKDB4guAMWhSFrEIvzKm/mU53rKWVLk4fTP9onUT qULVksJutGmFQES5MNvSYZeOznqSfnIqaOs8TMOo= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Samuel Thibault To: glibc-cvs@sourceware.org Subject: [glibc] htl: Respect GL(dl_stack_flags) when allocating stacks X-Act-Checkin: glibc X-Git-Author: Sergey Bugaev X-Git-Refname: refs/heads/master X-Git-Oldrev: b467cfcaee34452df845c678dd2ba36ea2221855 X-Git-Newrev: a4273efa219480a7f2c9c8fa7bc8bb71c48c3604 Message-Id: <20240323221642.0D78F3858D38@sourceware.org> Date: Sat, 23 Mar 2024 22:16:41 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=a4273efa219480a7f2c9c8fa7bc8bb71c48c3604 commit a4273efa219480a7f2c9c8fa7bc8bb71c48c3604 Author: Sergey Bugaev Date: Sat Mar 23 20:32:47 2024 +0300 htl: Respect GL(dl_stack_flags) when allocating stacks Previously, HTL would always allocate non-executable stacks. This has never been noticed, since GNU Mach on x86 ignores VM_PROT_EXECUTE and makes all pages implicitly executable. Since GNU Mach on AArch64 supports non-executable pages, HTL forgetting to pass VM_PROT_EXECUTE immediately breaks any code that (unfortunately, still) relies on executable stacks. Signed-off-by: Sergey Bugaev Message-ID: <20240323173301.151066-7-bugaevc@gmail.com> Diff: --- sysdeps/htl/Versions | 4 ++++ sysdeps/mach/htl/pt-stack-alloc.c | 9 +++++++-- 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/sysdeps/htl/Versions b/sysdeps/htl/Versions index 3a3b1e8b3d..7b5450d20e 100644 --- a/sysdeps/htl/Versions +++ b/sysdeps/htl/Versions @@ -12,4 +12,8 @@ libc { pthread_spin_destroy; pthread_spin_init; pthread_spin_lock; pthread_spin_trylock; pthread_spin_unlock; } + + GLIBC_PRIVATE { + __vm_map; + } } diff --git a/sysdeps/mach/htl/pt-stack-alloc.c b/sysdeps/mach/htl/pt-stack-alloc.c index 61974bd571..0597770bab 100644 --- a/sysdeps/mach/htl/pt-stack-alloc.c +++ b/sysdeps/mach/htl/pt-stack-alloc.c @@ -31,9 +31,14 @@ int __pthread_stack_alloc (void **stackaddr, size_t stacksize) { error_t err; + vm_prot_t prot = VM_PROT_READ | VM_PROT_WRITE; - err = __vm_allocate (__mach_task_self (), (vm_offset_t *) stackaddr, - stacksize, TRUE); + if (GL(dl_stack_flags) & PF_X) + prot |= VM_PROT_EXECUTE; + + err = __vm_map (__mach_task_self (), (vm_offset_t *) stackaddr, + stacksize, 0, TRUE, MEMORY_OBJECT_NULL, 0, FALSE, + prot, VM_PROT_ALL, VM_INHERIT_COPY); if (err == KERN_NO_SPACE) err = EAGAIN;