public inbox for glibc-cvs@sourceware.org help / color / mirror / Atom feed
From: Adhemerval Zanella <azanella@sourceware.org> To: glibc-cvs@sourceware.org Subject: [glibc/azanella/clang] support: Suppress clang warning on tst-timespec Date: Tue, 2 Apr 2024 15:57:02 +0000 (GMT) [thread overview] Message-ID: <20240402155702.120DB3858286@sourceware.org> (raw) https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=c07ea9b930161b4d9cf810707650fd32137e848c commit c07ea9b930161b4d9cf810707650fd32137e848c Author: Adhemerval Zanella <adhemerval.zanella@linaro.org> Date: Fri Mar 25 11:26:46 2022 -0300 support: Suppress clang warning on tst-timespec clang warns that converting from TIME_T_MAX to double (upper_bound) loses precision (from 9223372036854775807 to 9223372036854775808): tst-timespec.c:290:19: error: implicit conversion from 'time_t' (aka 'long') to 'double' changes value from 9223372036854775807 to 9223372036854775808 [-Werror,-Wimplicit-const-int-float-conversion] .upper_bound = TIME_T_MAX, .lower_bound = 1, .result = 1, ^~~~~~~~~~ tst-timespec.c:48:20: note: expanded from macro 'TIME_T_MAX' #define TIME_T_MAX TYPE_MAXIMUM (time_t) ^~~~~~~~~~~~~~~~~~~~~ ../include/intprops.h:57:4: note: expanded from macro 'TYPE_MAXIMUM' ((t) (! TYPE_SIGNED (t) \ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ It does not matter for the test. Checked on x86_64-linux-gnu. Diff: --- support/tst-timespec.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/support/tst-timespec.c b/support/tst-timespec.c index 66fc42c03d..d622e741ec 100644 --- a/support/tst-timespec.c +++ b/support/tst-timespec.c @@ -20,6 +20,7 @@ #include <support/check.h> #include <limits.h> #include <intprops.h> +#include <libc-diag.h> #define TIMESPEC_HZ 1000000000 @@ -179,6 +180,11 @@ struct timespec_norm_test_case norm_cases[] = { } }; +/* clang warns that converting from TIME_T_MAX to double (upper_bound) + loses precision (from 9223372036854775807 to 9223372036854775808). + It does not matter in tests below. */ +DIAG_PUSH_NEEDS_COMMENT_CLANG; +DIAG_IGNORE_NEEDS_COMMENT_CLANG (13, "-Wimplicit-const-int-float-conversion"); /* Test cases for timespec_check_in_range */ struct timespec_test_case check_cases[] = { /* 0 - In range */ @@ -290,6 +296,7 @@ struct timespec_test_case check_cases[] = { .upper_bound = TIME_T_MAX, .lower_bound = 1, .result = 1, }, }; +DIAG_POP_NEEDS_COMMENT_CLANG; static int do_test (void)
next reply other threads:[~2024-04-02 15:57 UTC|newest] Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-04-02 15:57 Adhemerval Zanella [this message] -- strict thread matches above, loose matches on Subject: below -- 2025-03-25 20:24 Adhemerval Zanella 2024-04-17 20:10 Adhemerval Zanella 2024-02-09 17:35 Adhemerval Zanella 2024-02-07 14:10 Adhemerval Zanella 2024-01-29 18:00 Adhemerval Zanella 2023-12-21 18:57 Adhemerval Zanella 2023-09-28 17:55 Adhemerval Zanella 2023-08-30 12:40 Adhemerval Zanella 2023-02-09 19:51 Adhemerval Zanella 2022-10-28 17:45 Adhemerval Zanella 2022-10-04 13:02 Adhemerval Zanella 2022-06-09 21:23 Adhemerval Zanella 2022-06-09 13:20 Adhemerval Zanella 2022-06-03 14:09 Adhemerval Zanella 2022-05-13 14:23 Adhemerval Zanella 2022-05-12 19:37 Adhemerval Zanella 2022-05-10 18:27 Adhemerval Zanella 2022-04-29 14:07 Adhemerval Zanella 2022-04-04 12:58 Adhemerval Zanella 2022-03-31 19:10 Adhemerval Zanella 2022-03-29 20:34 Adhemerval Zanella
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20240402155702.120DB3858286@sourceware.org \ --to=azanella@sourceware.org \ --cc=glibc-cvs@sourceware.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).