public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Adhemerval Zanella <azanella@sourceware.org>
To: glibc-cvs@sourceware.org
Subject: [glibc/azanella/clang] resolve: Fix implicit conversion on tst-resolv-invalid-cname
Date: Tue,  2 Apr 2024 15:59:26 +0000 (GMT)	[thread overview]
Message-ID: <20240402155926.A6181385E03C@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=8e24b582016f513708e0cad65c2cbef024006346

commit 8e24b582016f513708e0cad65c2cbef024006346
Author: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Date:   Thu Sep 1 08:08:59 2022 -0300

    resolve: Fix implicit conversion on tst-resolv-invalid-cname
    
      tst-resolv-invalid-cname.c:313:17: error: implicit conversion from 'int'
      to 'char' changes value from 192 to -64 [-Werror,-Wconstant-conversion]
            addr[0] = 192;
                    ~ ^~~
      tst-resolv-invalid-cname.c:314:17: error: implicit conversion from 'int'
      to 'char' changes value from 168 to -88 [-Werror,-Wconstant-conversion]
            addr[1] = 168;
                    ~ ^~~

Diff:
---
 resolv/tst-resolv-invalid-cname.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/resolv/tst-resolv-invalid-cname.c b/resolv/tst-resolv-invalid-cname.c
index 69f1c63be1..7675a45950 100644
--- a/resolv/tst-resolv-invalid-cname.c
+++ b/resolv/tst-resolv-invalid-cname.c
@@ -310,8 +310,8 @@ check_reverse (int af, int bits, int count)
   socklen_t addrlen;
   if (af == AF_INET)
     {
-      addr[0] = 192;
-      addr[1] = 168;
+      addr[0] = 0xc0;
+      addr[1] = 0xa8;
       addr[2] = count;
       addr[3] = bits;
       addrlen = 4;

             reply	other threads:[~2024-04-02 15:59 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-02 15:59 Adhemerval Zanella [this message]
  -- strict thread matches above, loose matches on Subject: below --
2024-04-17 20:13 Adhemerval Zanella
2024-02-09 17:37 Adhemerval Zanella
2024-02-07 14:13 Adhemerval Zanella
2024-01-29 18:03 Adhemerval Zanella
2023-12-21 18:59 Adhemerval Zanella
2023-09-28 17:57 Adhemerval Zanella
2023-08-30 12:42 Adhemerval Zanella
2023-02-09 19:54 Adhemerval Zanella
2022-10-28 17:47 Adhemerval Zanella
2022-10-04 13:05 Adhemerval Zanella

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240402155926.A6181385E03C@sourceware.org \
    --to=azanella@sourceware.org \
    --cc=glibc-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).