From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1791) id 610BD385801D; Tue, 2 Apr 2024 16:00:02 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 610BD385801D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1712073602; bh=+w7AIlnA1CmWBHL7CNpp/vdPjPdsZf9FNR4De2MYKuk=; h=From:To:Subject:Date:From; b=K3q5H5haV2DnUvUkZolUsvPHKRnpS3fUaPAg6YpZxiOKiCHOtgc0D1xwa0nQYekbq +lvJxtgMT/LXx1YyFvLbDsmMyBYIZAikip16QJFSgDFsiKkitWFNhE7h3L52LhrpIc 9tuff0SLvablxM6Mr8MkQndL83tZi0sa/r968Omo= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Adhemerval Zanella To: glibc-cvs@sourceware.org Subject: [glibc/azanella/clang] i386: Disable some tests on clang X-Act-Checkin: glibc X-Git-Author: Adhemerval Zanella X-Git-Refname: refs/heads/azanella/clang X-Git-Oldrev: b3bb80c17567ef11cab70a9fc24d6656e58ccb79 X-Git-Newrev: 38831688eaebab0bce550d1a40fc20c8961c7d7e Message-Id: <20240402160002.610BD385801D@sourceware.org> Date: Tue, 2 Apr 2024 16:00:02 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=38831688eaebab0bce550d1a40fc20c8961c7d7e commit 38831688eaebab0bce550d1a40fc20c8961c7d7e Author: Adhemerval Zanella Date: Fri Jul 28 09:34:03 2023 -0300 i386: Disable some tests on clang clang generated R_I386_PC32 instead of R_386_PLT32 for static ifoo calls, which triggers an ld issues where it can not link non-PIC and PIC objects. This seems to be a clang bug. Diff: --- elf/ifuncmain9.c | 5 +++++ sysdeps/x86/tst-ifunc-isa-1.c | 5 +++++ sysdeps/x86/tst-ifunc-isa-2.c | 4 ++++ 3 files changed, 14 insertions(+) diff --git a/elf/ifuncmain9.c b/elf/ifuncmain9.c index a13020dc6d..ed9c5a5d86 100644 --- a/elf/ifuncmain9.c +++ b/elf/ifuncmain9.c @@ -23,6 +23,7 @@ # include # include # include +# include /* Do not use the test framework, so that the process setup is not disturbed. */ @@ -57,6 +58,9 @@ DIAG_POP_NEEDS_COMMENT_CLANG; int main (void) { +#if defined __clang__ && defined __i386__ + return EXIT_UNSUPPORTED; +#else bool errors = false; if (implementation_called != 0) @@ -93,4 +97,5 @@ main (void) } return errors; +#endif } diff --git a/sysdeps/x86/tst-ifunc-isa-1.c b/sysdeps/x86/tst-ifunc-isa-1.c index 44726576f1..276efc0572 100644 --- a/sysdeps/x86/tst-ifunc-isa-1.c +++ b/sysdeps/x86/tst-ifunc-isa-1.c @@ -17,14 +17,19 @@ . */ #include +#include #include "tst-ifunc-isa.h" static int do_test (void) { +#if defined __clang__ && defined __i386__ + return EXIT_UNSUPPORTED; +#else enum isa value = foo (); enum isa expected = get_isa (); return value == expected ? EXIT_SUCCESS : EXIT_FAILURE; +#endif } #include diff --git a/sysdeps/x86/tst-ifunc-isa-2.c b/sysdeps/x86/tst-ifunc-isa-2.c index 156c649807..130169b614 100644 --- a/sysdeps/x86/tst-ifunc-isa-2.c +++ b/sysdeps/x86/tst-ifunc-isa-2.c @@ -23,12 +23,16 @@ static int do_test (void) { +#if defined __clang__ && defined __i386__ + return EXIT_UNSUPPORTED; +#else /* CPU must support SSE2. */ if (!__builtin_cpu_supports ("sse2")) return EXIT_UNSUPPORTED; enum isa value = foo (); /* All ISAs, but SSE2, are disabled by tunables. */ return value == sse2 ? EXIT_SUCCESS : EXIT_FAILURE; +#endif } #include