From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2178) id 8B7333858C39; Mon, 8 Apr 2024 17:19:20 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8B7333858C39 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1712596760; bh=Lxj8+PsQjJPmbDZqFy2dSI0BYqed9b1rBKMMDhlJNxs=; h=From:To:Subject:Date:From; b=c5lPUHPeNwWvqlgkqOLjbLhwH6XECgxV+GsAl4DwQNC0iub65MbMJdV4HrVxPGNay tEO1fOBCPjI5D2XptzcaO1Ft3+NuTM+evkquYt41aO+fALQa3PJ3V9+rNhDH75wUN6 oa/aOCYnlV37A/AeQ2mkN4+LTs6HISzUC4TWk83w= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Florian Weimer To: glibc-cvs@sourceware.org Subject: [glibc] elf: Add ld.so test with non-existing program name X-Act-Checkin: glibc X-Git-Author: Florian Weimer X-Git-Refname: refs/heads/master X-Git-Oldrev: 1cce91d8aed5c3eca2b6f47767c82d9ed3e9e33f X-Git-Newrev: ae7468a7b0bcf22e9cd5fcae42bb9e4f65de83ee Message-Id: <20240408171920.8B7333858C39@sourceware.org> Date: Mon, 8 Apr 2024 17:19:20 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=ae7468a7b0bcf22e9cd5fcae42bb9e4f65de83ee commit ae7468a7b0bcf22e9cd5fcae42bb9e4f65de83ee Author: Florian Weimer Date: Mon Apr 8 19:19:09 2024 +0200 elf: Add ld.so test with non-existing program name None of the existing tests seem to cover the case where _dl_signal_error is called without an active error handler. The new elf/tst-rtld-does-not-exist test triggers such a _dl_signal_error call from _dl_map_object. Reviewed-by: H.J. Lu Diff: --- elf/Makefile | 7 +++++++ elf/tst-rtld-does-not-exist.sh | 39 +++++++++++++++++++++++++++++++++++++++ 2 files changed, 46 insertions(+) diff --git a/elf/Makefile b/elf/Makefile index 4f1903391a..6dad11bcfb 100644 --- a/elf/Makefile +++ b/elf/Makefile @@ -621,6 +621,13 @@ $(objpfx)tst-valgrind-smoke.out: tst-valgrind-smoke.sh $(objpfx)ld.so $(objpfx)v '$(run-program-env)' '$(rpath-link)' $(objpfx)valgrind-test \ '$(valgrind-suppressions-tst-valgrind-smoke)' > $@; $(evaluate-test) +ifeq ($(run-built-tests),yes) +tests-special += $(objpfx)tst-rtld-does-not-exist.out +endif +$(objpfx)tst-rtld-does-not-exist.out: tst-rtld-does-not-exist.sh $(objpfx)ld.so + $(SHELL) $< $(objpfx)ld.so > $@; \ + $(evaluate-test) + tests += $(tests-execstack-$(have-z-execstack)) ifeq ($(run-built-tests),yes) tests-special += \ diff --git a/elf/tst-rtld-does-not-exist.sh b/elf/tst-rtld-does-not-exist.sh new file mode 100644 index 0000000000..a4a781ccfd --- /dev/null +++ b/elf/tst-rtld-does-not-exist.sh @@ -0,0 +1,39 @@ +#!/bin/sh +# Check that running ld.so with a non-existing file prints an error. +# Copyright (C) 2024 Free Software Foundation, Inc. +# This file is part of the GNU C Library. + +# The GNU C Library is free software; you can redistribute it and/or +# modify it under the terms of the GNU Lesser General Public +# License as published by the Free Software Foundation; either +# version 2.1 of the License, or (at your option) any later version. + +# The GNU C Library is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU +# Lesser General Public License for more details. + +# You should have received a copy of the GNU Lesser General Public +# License along with the GNU C Library; if not, see +# . + +export LC_ALL=C + +rtld="$1" +tmp_out="$(mktemp)" + +$rtld program-does-not-exist 2>"$tmp_out" +status=$? +echo "$rtld exit status: $status" +echo "output (with expected error):" +cat "$tmp_out" + +if test $status -eq 127 \ + && grep -q "^program-does-not-exist: error while loading shared libraries: program-does-not-exist: cannot open shared object file$" "$tmp_out" \ + && test "$(wc -l < "$tmp_out")" -eq 1 ; then + status=0 +else + status=1 +fi +rm "$tmp_out" +exit $status