From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1791) id D889D385841E; Wed, 17 Apr 2024 20:04:36 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D889D385841E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1713384276; bh=/iFZKkUAcruCHGcoVGR1Ty29x9ZEQZJUb4AQuhiWb6g=; h=From:To:Subject:Date:From; b=snXrcTmV37U4nyJ9AZMyMvaEZhwMXmxPBj+QgD20FldT4PolsduE8FuXXUZ4Ty7w1 nmIl9M06KxvxlP/0i06H3OZETIy+xVXL4ooI3ugJZGmIxmFLm9hfVTalaO0QJlB5qq MqkDdh+919ffmj95FHWXc5Z1AGLceN1ZSPDxBVH8= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Adhemerval Zanella To: glibc-cvs@sourceware.org Subject: [glibc/azanella/clang] Disable __USE_EXTERN_INLINES for clang X-Act-Checkin: glibc X-Git-Author: Adhemerval Zanella X-Git-Refname: refs/heads/azanella/clang X-Git-Oldrev: e182dc08d71c8268495acc1a980a7fb57fa84103 X-Git-Newrev: d2765f0fa2c6292ad25cfc6a74b91aa7ec0ea01a Message-Id: <20240417200436.D889D385841E@sourceware.org> Date: Wed, 17 Apr 2024 20:04:36 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=d2765f0fa2c6292ad25cfc6a74b91aa7ec0ea01a commit d2765f0fa2c6292ad25cfc6a74b91aa7ec0ea01a Author: Adhemerval Zanella Date: Thu Oct 7 18:16:04 2021 -0700 Disable __USE_EXTERN_INLINES for clang clang does not allow to redefine attributes after function declaration. Although it work for external usage, its breaks the build for internal symbol that glibc provides as optimization (for instance bsearch with stdlib-bsearch.h or __cmsg_nxthdr). Disable such optimization for clang while building glibc. Diff: --- include/features.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/features.h b/include/features.h index d92503dfed..23e29b9f4d 100644 --- a/include/features.h +++ b/include/features.h @@ -523,7 +523,7 @@ /* Decide whether we can define 'extern inline' functions in headers. */ #if __GNUC_PREREQ (2, 7) && defined __OPTIMIZE__ \ && !defined __OPTIMIZE_SIZE__ && !defined __NO_INLINE__ \ - && defined __extern_inline + && defined __extern_inline && !(defined __clang__ && defined _LIBC) # define __USE_EXTERN_INLINES 1 #endif