From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1791) id D4D493858CDB; Wed, 17 Apr 2024 20:10:31 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D4D493858CDB DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1713384631; bh=E633+a6TqEZnMD0Ci9Jl1438iqc516Z2fmn+sDwqU4k=; h=From:To:Subject:Date:From; b=r0Q1EDveDIdkBhLxcDR0rnHytf+emhan6pfX+p6fgJmz9xF1glHnBo91ONPO1wEwc QYLe6nUGK85ikxZq1pP2Ho07n2hfd8xEZFVcSFyHfvT4I/HK2G3x8GVR32F8YIXjHW egGldrv9CWMv8+pTr4+RUV7DcOUcXhS/5tCQFwJM= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Adhemerval Zanella To: glibc-cvs@sourceware.org Subject: [glibc/azanella/clang] dirent: Remove variable lenght array structure for tst-getdents64.c X-Act-Checkin: glibc X-Git-Author: Adhemerval Zanella X-Git-Refname: refs/heads/azanella/clang X-Git-Oldrev: 58235f6e00583efd2af47e4fa746cc9be9f19190 X-Git-Newrev: 790e19f1d14a247289e18842c9d8e7c0ca1d7b79 Message-Id: <20240417201031.D4D493858CDB@sourceware.org> Date: Wed, 17 Apr 2024 20:10:31 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=790e19f1d14a247289e18842c9d8e7c0ca1d7b79 commit 790e19f1d14a247289e18842c9d8e7c0ca1d7b79 Author: Adhemerval Zanella Date: Fri Mar 25 09:03:03 2022 -0300 dirent: Remove variable lenght array structure for tst-getdents64.c Clang emits the following warnings: ../sysdeps/unix/sysv/linux/tst-getdents64.c:111:18: error: fields must have a constant size: 'variable length array in structure' extension will never be supported char buffer[buffer_size]; ^ Diff: --- sysdeps/unix/sysv/linux/tst-getdents64.c | 16 +++++----------- 1 file changed, 5 insertions(+), 11 deletions(-) diff --git a/sysdeps/unix/sysv/linux/tst-getdents64.c b/sysdeps/unix/sysv/linux/tst-getdents64.c index 3dd22a4e03..458627bac1 100644 --- a/sysdeps/unix/sysv/linux/tst-getdents64.c +++ b/sysdeps/unix/sysv/linux/tst-getdents64.c @@ -96,6 +96,8 @@ do_test_by_size (size_t buffer_size) int fd = xopen (".", O_RDONLY | O_DIRECTORY, 0); TEST_VERIFY (fd >= 0); + char *data = xposix_memalign (_Alignof (struct dirent64), buffer_size); + /* Perform two passes, with a rewind operating between passes. */ for (int pass = 0; pass < 2; ++pass) { @@ -104,23 +106,15 @@ do_test_by_size (size_t buffer_size) while (true) { - /* Simple way to make sure that the memcpy below does not read - non-existing data. */ - struct - { - char buffer[buffer_size]; - struct dirent64 pad; - } data; - - ssize_t ret = getdents64 (fd, &data.buffer, sizeof (data.buffer)); + ssize_t ret = getdents64 (fd, data, buffer_size); if (ret < 0) FAIL_EXIT1 ("getdents64: %m"); if (ret == 0) break; ++read_count; - char *current = data.buffer; - char *end = data.buffer + ret; + char *current = data; + char *end = data + ret; while (current != end) { struct dirent64 entry;