From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2178) id 70A0C3846410; Thu, 25 Apr 2024 13:32:19 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 70A0C3846410 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1714051939; bh=PBzqQ10ERtic3SPR+iVW1jPgcj8omADA/Pmhe32g8qU=; h=From:To:Subject:Date:From; b=SQatlVIWk1T2dDveQawdCR5K/tyx/n3D7R8Wg+BvPFcAU+Nslfk7RN7LK5sEeMzK5 ITLhyPYhD3AxaxLM0V4WsGYcqHSk5mqNn/aU1iGrvnqQOgH31YTFEGGDRmIlS/afmM DBJ978eR4JFzQ7xREzvUCpoc88PLgmXnaX0vnYO4= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Florian Weimer To: glibc-cvs@sourceware.org Subject: [glibc] CVE-2024-33599: nscd: Stack-based buffer overflow in netgroup cache (bug 31677) X-Act-Checkin: glibc X-Git-Author: Florian Weimer X-Git-Refname: refs/heads/master X-Git-Oldrev: 3a3a4497421422aa854c855cbe5110ca7d598ffc X-Git-Newrev: 87801a8fd06db1d654eea3e4f7626ff476a9bdaa Message-Id: <20240425133219.70A0C3846410@sourceware.org> Date: Thu, 25 Apr 2024 13:32:19 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=87801a8fd06db1d654eea3e4f7626ff476a9bdaa commit 87801a8fd06db1d654eea3e4f7626ff476a9bdaa Author: Florian Weimer Date: Thu Apr 25 15:00:45 2024 +0200 CVE-2024-33599: nscd: Stack-based buffer overflow in netgroup cache (bug 31677) Using alloca matches what other caches do. The request length is bounded by MAXKEYLEN. Reviewed-by: Carlos O'Donell Diff: --- nscd/netgroupcache.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/nscd/netgroupcache.c b/nscd/netgroupcache.c index 0c6e46f15c..f227dc7fa2 100644 --- a/nscd/netgroupcache.c +++ b/nscd/netgroupcache.c @@ -502,12 +502,13 @@ addinnetgrX (struct database_dyn *db, int fd, request_header *req, = (struct indataset *) mempool_alloc (db, sizeof (*dataset) + req->key_len, 1); - struct indataset dataset_mem; bool cacheable = true; if (__glibc_unlikely (dataset == NULL)) { cacheable = false; - dataset = &dataset_mem; + /* The alloca is safe because nscd_run_worker verfies that + key_len is not larger than MAXKEYLEN. */ + dataset = alloca (sizeof (*dataset) + req->key_len); } datahead_init_pos (&dataset->head, sizeof (*dataset) + req->key_len,