From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 2178) id 82DF43858D20; Thu, 25 Apr 2024 14:13:16 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 82DF43858D20 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1714054396; bh=HTAPnZ3nr2JsAVkIW7EQKl3RY6EaqySOrv5Nq9vA5jA=; h=From:To:Subject:Date:From; b=UoDHV7zO6AJLGYGNTaW6RjxHrpbIXVzZP/C9gqmbuTIl/PtbjgoXzBtVe7dWVfwBp aNsqDXmnflKoceGj+U6HxQLsib9ubGL0/AuNkr2VEA6UNJbxro0yDvx29CWo73+Vmp S+mb3hG7xbv9qHICm7gggZC5GSuT/owphq7dg7zo= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Florian Weimer To: glibc-cvs@sourceware.org Subject: [glibc/release/2.31/master] CVE-2024-33599: nscd: Stack-based buffer overflow in netgroup cache (bug 31677) X-Act-Checkin: glibc X-Git-Author: Florian Weimer X-Git-Refname: refs/heads/release/2.31/master X-Git-Oldrev: 3703c32a8d304c1ee12126134ce69be965f38000 X-Git-Newrev: 69c58d5ef9f584ea198bd00f7964d364d0e6b921 Message-Id: <20240425141316.82DF43858D20@sourceware.org> Date: Thu, 25 Apr 2024 14:13:16 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=69c58d5ef9f584ea198bd00f7964d364d0e6b921 commit 69c58d5ef9f584ea198bd00f7964d364d0e6b921 Author: Florian Weimer Date: Thu Apr 25 15:00:45 2024 +0200 CVE-2024-33599: nscd: Stack-based buffer overflow in netgroup cache (bug 31677) Using alloca matches what other caches do. The request length is bounded by MAXKEYLEN. Reviewed-by: Carlos O'Donell (cherry picked from commit 87801a8fd06db1d654eea3e4f7626ff476a9bdaa) Diff: --- nscd/netgroupcache.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/nscd/netgroupcache.c b/nscd/netgroupcache.c index 381aa721ef..a833ef039e 100644 --- a/nscd/netgroupcache.c +++ b/nscd/netgroupcache.c @@ -503,12 +503,13 @@ addinnetgrX (struct database_dyn *db, int fd, request_header *req, = (struct indataset *) mempool_alloc (db, sizeof (*dataset) + req->key_len, 1); - struct indataset dataset_mem; bool cacheable = true; if (__glibc_unlikely (dataset == NULL)) { cacheable = false; - dataset = &dataset_mem; + /* The alloca is safe because nscd_run_worker verfies that + key_len is not larger than MAXKEYLEN. */ + dataset = alloca (sizeof (*dataset) + req->key_len); } datahead_init_pos (&dataset->head, sizeof (*dataset) + req->key_len,