public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Sunil Pandey <skpgkp2@sourceware.org>
To: glibc-cvs@sourceware.org
Subject: [glibc/release/2.28/master] testsuite: stdlib/isomac.c: add missing include
Date: Fri, 10 May 2024 02:55:42 +0000 (GMT)	[thread overview]
Message-ID: <20240510025542.68B57385840E@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=c0a523f13b0868d03046a7e479fe5fb7039bd397

commit c0a523f13b0868d03046a7e479fe5fb7039bd397
Author: Aurelien Jarno <aurelien@aurel32.net>
Date:   Tue Jan 8 21:10:28 2019 +0100

    testsuite: stdlib/isomac.c: add missing include
    
    When running the testsuite, building stdlib/isomac.c outputs the
    following warning:
    
      gcc -O   -D_GNU_SOURCE -DIS_IN_build -include /home/aurel32/glibc-build/config.h isomac.c -o /home/aurel32/glibc-build/stdlib/isomac
      isomac.c: In function ‘get_null_defines’:
      isomac.c:260:3: warning: implicit declaration of function ‘close’; did you mean ‘pclose’? [-Wimplicit-function-declaration]
         close (fd);
         ^~~~~
         pclose
    
    Fix that by adding the <unistd.h> include.
    
    Changelog:
            * stdlib/isomac.c: Include <unistd.h>.
    (cherry picked from commit 11f382ee780649549428cb25af3a9f1d3465868d)

Diff:
---
 ChangeLog       | 4 ++++
 stdlib/isomac.c | 1 +
 2 files changed, 5 insertions(+)

diff --git a/ChangeLog b/ChangeLog
index f9157d179b..95b7e2a59e 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,7 @@
+2019-02-03  Aurelien Jarno  <aurelien@aurel32.net>
+
+	* stdlib/isomac.c: Include <unistd.h>.
+
 2018-11-07  Florian Weimer  <fweimer@redhat.com>
 
 	Implement TEST_COMPARE_STRING.
diff --git a/stdlib/isomac.c b/stdlib/isomac.c
index 0873eaa505..439b000734 100644
--- a/stdlib/isomac.c
+++ b/stdlib/isomac.c
@@ -74,6 +74,7 @@
 #include <stdio.h>
 #include <stdlib.h>
 #include <string.h>
+#include <unistd.h>
 
 #define HEADER_MAX          256

                 reply	other threads:[~2024-05-10  2:55 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240510025542.68B57385840E@sourceware.org \
    --to=skpgkp2@sourceware.org \
    --cc=glibc-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).