From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by sourceware.org (Postfix, from userid 1792) id 02C4F385700F; Mon, 10 Jun 2024 20:08:52 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 02C4F385700F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1718050133; bh=A+6S8vUforj/UXJxZOEWFddWgbTnYgsmv38w6P/khDY=; h=From:To:Subject:Date:From; b=nW2vkkI9DSX9Y/imjMwASgSe92uLE9voBfai7yC+J4bYJa8MxCxPfLH6cwvGadNV+ TPReBhOxF8qak9h+wtGADtPnY+xp2mCZoXwg+izuaOJXL27pkawzWicfVlIRMcTq3J NWsHTXtrAbpbYL9MY2FUz5sUbZl4kM2lEp0S95YQ= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: Samuel Thibault To: glibc-cvs@sourceware.org Subject: [glibc] hurd: Fix getxattr("gnu.translator") returning ENODATA X-Act-Checkin: glibc X-Git-Author: Samuel Thibault X-Git-Refname: refs/heads/master X-Git-Oldrev: 74f9ee3b91931967df5601ad63a4b02f5cd75b43 X-Git-Newrev: ba5a23422a156804234dff6c5be89e20ee8f9ec2 Message-Id: <20240610200853.02C4F385700F@sourceware.org> Date: Mon, 10 Jun 2024 20:08:52 +0000 (GMT) List-Id: https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=ba5a23422a156804234dff6c5be89e20ee8f9ec2 commit ba5a23422a156804234dff6c5be89e20ee8f9ec2 Author: Samuel Thibault Date: Mon Jun 10 21:57:53 2024 +0200 hurd: Fix getxattr("gnu.translator") returning ENODATA When no translator is set, __file_get_translator would return EINVAL which is a confusing value. Better check for a passive translation before getting the value. Diff: --- hurd/xattr.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/hurd/xattr.c b/hurd/xattr.c index 0715ad7b02..f613d47c83 100644 --- a/hurd/xattr.c +++ b/hurd/xattr.c @@ -61,7 +61,16 @@ _hurd_xattr_get (io_t port, const char *name, void *value, size_t *size) { char *buf = value; mach_msg_type_number_t bufsz = value ? *size : 0; - error_t err = __file_get_translator (port, &buf, &bufsz); + struct stat64 st; + error_t err; + + err = __io_stat (port, &st); + if (err) + return err; + if ((st.st_mode & S_IPTRANS) == 0) + return ENODATA; + + err = __file_get_translator (port, &buf, &bufsz); if (err) return err; if (value != NULL && *size < bufsz)