public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
* [glibc] inet: Avoid label at end of compound statement in tst-if_nameindex
@ 2024-08-21 17:16 Florian Weimer
  0 siblings, 0 replies; 2+ messages in thread
From: Florian Weimer @ 2024-08-21 17:16 UTC (permalink / raw)
  To: glibc-cvs

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=26aca73db5e5ea299b554ceae418b13102b24948

commit 26aca73db5e5ea299b554ceae418b13102b24948
Author: Florian Weimer <fweimer@redhat.com>
Date:   Wed Aug 21 19:13:10 2024 +0200

    inet: Avoid label at end of compound statement in tst-if_nameindex
    
    This fails to compile with GCC 8.

Diff:
---
 inet/tst-if_nameindex.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/inet/tst-if_nameindex.c b/inet/tst-if_nameindex.c
index b025cdb3a7..1027182ef5 100644
--- a/inet/tst-if_nameindex.c
+++ b/inet/tst-if_nameindex.c
@@ -96,15 +96,13 @@ do_test (void)
       /* Make sure our "invalid" name is really invalid.  */
       for (ifp = if_ni; !(ifp->if_index == 0 && ifp->if_name == NULL); ifp++)
 	if (strcmp (test_names[i], ifp->if_name) == 0)
-	  goto not_this_one;
+	  continue;
 
       printf ("Testing if_nametoindex (%s) == 0\n", test_names[i]);
 
       unsigned int idx = if_nametoindex (test_names[i]);
       TEST_VERIFY (idx == 0);
       TEST_VERIFY (errno == ENODEV);
-
-    not_this_one:
     }

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [glibc] inet: Avoid label at end of compound statement in tst-if_nameindex
@ 2024-08-26 14:45 Florian Weimer
  0 siblings, 0 replies; 2+ messages in thread
From: Florian Weimer @ 2024-08-26 14:45 UTC (permalink / raw)
  To: glibc-cvs

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=79f44e1a47e87907fb8e97bbd098e01c4adc26a5

commit 79f44e1a47e87907fb8e97bbd098e01c4adc26a5
Author: Florian Weimer <fweimer@redhat.com>
Date:   Mon Aug 26 16:45:31 2024 +0200

    inet: Avoid label at end of compound statement in tst-if_nameindex
    
    This fails to compile with GCC 8.

Diff:
---
 inet/tst-if_nameindex.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/inet/tst-if_nameindex.c b/inet/tst-if_nameindex.c
index b025cdb3a7..5b90560124 100644
--- a/inet/tst-if_nameindex.c
+++ b/inet/tst-if_nameindex.c
@@ -105,6 +105,7 @@ do_test (void)
       TEST_VERIFY (errno == ENODEV);
 
     not_this_one:
+      ;
     }

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-08-26 14:45 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-08-21 17:16 [glibc] inet: Avoid label at end of compound statement in tst-if_nameindex Florian Weimer
2024-08-26 14:45 Florian Weimer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).