public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Adhemerval Zanella <azanella@sourceware.org>
To: glibc-cvs@sourceware.org
Subject: [glibc/azanella/clang] string: Suppress clang confstr -Wignored-attributes on strlen
Date: Tue, 25 Mar 2025 20:23:26 +0000 (GMT)	[thread overview]
Message-ID: <20250325202326.A44BF385783C@sourceware.org> (raw)

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=247526a5a30d542c147b0999ad094327b1e0bd47

commit 247526a5a30d542c147b0999ad094327b1e0bd47
Author: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Date:   Thu Sep 28 14:18:54 2023 -0300

    string: Suppress clang confstr -Wignored-attributes on strlen
    
    clang warns that the alias will be always resolve to __strlen
    even if weak definition of __GI_strlen is overridden, which is
    really the intention.

Diff:
---
 string/strlen.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/string/strlen.c b/string/strlen.c
index 4d95d57521..d448f64993 100644
--- a/string/strlen.c
+++ b/string/strlen.c
@@ -48,5 +48,10 @@ __strlen (const char *str)
 }
 #ifndef STRLEN
 weak_alias (__strlen, strlen)
+/* clang warns that the alias will be always resolve to __strlen even if weak
+   definition of __GI_strlen is overridden, which is really the intention.  */
+DIAG_PUSH_NEEDS_COMMENT_CLANG;
+DIAG_IGNORE_NEEDS_COMMENT_CLANG (16, "-Wignored-attributes");
 libc_hidden_builtin_def (strlen)
+DIAG_POP_NEEDS_COMMENT_CLANG;
 #endif

             reply	other threads:[~2025-03-25 20:23 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-25 20:23 Adhemerval Zanella [this message]
  -- strict thread matches above, loose matches on Subject: below --
2024-04-17 20:08 Adhemerval Zanella
2024-04-02 15:54 Adhemerval Zanella
2024-02-09 17:32 Adhemerval Zanella
2024-02-07 14:08 Adhemerval Zanella
2024-01-29 17:58 Adhemerval Zanella
2023-12-21 18:54 Adhemerval Zanella
2023-09-28 17:53 Adhemerval Zanella

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250325202326.A44BF385783C@sourceware.org \
    --to=azanella@sourceware.org \
    --cc=glibc-cvs@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).