public inbox for glibc-cvs@sourceware.org
help / color / mirror / Atom feed
From: Adhemerval Zanella <azanella@sourceware.org>
To: glibc-cvs@sourceware.org
Subject: [glibc/azanella/clang] sunrpc: Suppress clang warning on struct cmessage
Date: Thu, 10 Apr 2025 18:12:33 +0000 (GMT) [thread overview]
Message-ID: <20250410181233.1D8833836C29@sourceware.org> (raw)
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=53bce5952b70dda097a53dd7f964890cd0a180e7
commit 53bce5952b70dda097a53dd7f964890cd0a180e7
Author: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Date: Thu Mar 10 14:08:06 2022 -0300
sunrpc: Suppress clang warning on struct cmessage
clang complains if a flexible array member (struct cmsghdr) is not a
the end of the struct (since it is a GNU extension). The __msgread
explicit expects that 'struct ucred' is after the 'cmsg', so suppress
the warning.
Diff:
---
sunrpc/svc_unix.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/sunrpc/svc_unix.c b/sunrpc/svc_unix.c
index 2743c1419a..4ae3784f4d 100644
--- a/sunrpc/svc_unix.c
+++ b/sunrpc/svc_unix.c
@@ -65,6 +65,7 @@
#include <libintl.h>
#include <wchar.h>
#include <shlib-compat.h>
+#include <libc-diag.h>
/*
* Ops vector for AF_UNIX based rpc service handle
@@ -308,12 +309,18 @@ svcunix_destroy (SVCXPRT *xprt)
}
#ifdef SCM_CREDENTIALS
+/* clang complains if a flexible array member (struct cmsghdr) is not a the
+ end of the struct (since it is a GNU extension). The __msgread explicit
+ expects that 'struct ucred' is after the 'cmsg', so disable the warning. */
+DIAG_PUSH_NEEDS_COMMENT_CLANG;
+DIAG_IGNORE_NEEDS_COMMENT_CLANG (18, "-Wgnu-variable-sized-type-not-at-end");
struct cmessage {
struct cmsghdr cmsg;
struct ucred cmcred;
/* hack to make sure we have enough memory */
char dummy[(CMSG_ALIGN (sizeof (struct ucred)) - sizeof (struct ucred) + sizeof (long))];
};
+DIAG_POP_NEEDS_COMMENT_CLANG;
/* XXX This is not thread safe, but since the main functions in svc.c
and the rpcgen generated *_svc functions for the daemon are also not
next reply other threads:[~2025-04-10 18:12 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-10 18:12 Adhemerval Zanella [this message]
-- strict thread matches above, loose matches on Subject: below --
2025-03-25 20:20 Adhemerval Zanella
2024-04-17 20:05 Adhemerval Zanella
2024-04-02 15:51 Adhemerval Zanella
2024-02-09 17:29 Adhemerval Zanella
2024-02-07 14:05 Adhemerval Zanella
2024-01-29 17:55 Adhemerval Zanella
2023-12-21 18:52 Adhemerval Zanella
2023-09-28 17:50 Adhemerval Zanella
2023-08-30 12:35 Adhemerval Zanella
2023-02-09 19:47 Adhemerval Zanella
2022-10-28 17:40 Adhemerval Zanella
2022-10-04 12:57 Adhemerval Zanella
2022-06-09 21:18 Adhemerval Zanella
2022-06-09 13:15 Adhemerval Zanella
2022-06-03 14:04 Adhemerval Zanella
2022-05-13 14:18 Adhemerval Zanella
2022-05-12 19:32 Adhemerval Zanella
2022-05-10 18:22 Adhemerval Zanella
2022-04-29 14:02 Adhemerval Zanella
2022-04-04 12:52 Adhemerval Zanella
2022-03-31 19:05 Adhemerval Zanella
2022-03-29 20:28 Adhemerval Zanella
2022-03-16 18:01 Adhemerval Zanella
2022-03-15 18:38 Adhemerval Zanella
2022-03-11 17:22 Adhemerval Zanella
2022-03-10 19:21 Adhemerval Zanella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250410181233.1D8833836C29@sourceware.org \
--to=azanella@sourceware.org \
--cc=glibc-cvs@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).