From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2a07:de40:b251:101:10:150:64:1]) by sourceware.org (Postfix) with ESMTPS id D24DF3858D32; Mon, 12 Feb 2024 13:36:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D24DF3858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D24DF3858D32 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707745016; cv=none; b=xEzj0Zzuak3iuRtVS2esqiADRt6U4PhgydKj+pmHKlNYXJRNA5rhki4BM5t+hE4LduM56dS/ZFT5LJjr5N6BtpMrbX5Iw04aX6K0Zswl5AsoEolpGR/QNWrW5JprpCEZNovAYyHpszYBhTM54/nN+/TXkrbfciWCOmBCkjP5VPo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707745016; c=relaxed/simple; bh=7z5cbWyphX2m8/ymu0IT1GbOFkcRRa530rqJL9Zk/Zs=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:From: To:Subject:Date:Message-ID:MIME-Version; b=q4WeCHWxtotDlDGWF4tKLVmUO2acB4PWTTMpzjbDJBkzHf/aGeqT198x3N8aWaKsPA5Fa8n6cSV2OYbYSc00xIJwzuNUyEKSadhH4FRbFiHTQWRF+qbkrjn1QWJAgbCd9D5/oxUeV9k7qQoyn35Ow/uVM/uNfPkWFB+H6frGyQ8= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from hawking.nue2.suse.org (unknown [10.168.4.11]) by smtp-out1.suse.de (Postfix) with ESMTP id C46FA21D6E; Mon, 12 Feb 2024 13:36:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1707745013; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pPBDHwov/gQzCIoZmZGL09sU8rD42LII0klGZX2DBs8=; b=pUnNIzx3Y5f1W1b9ql2I8z4pk+qOL87fj8tb/ItN8TF8D1sV4XqA3HnIUfEdsBtgCSzwXs Mrf8i6Po0Xr4QZQ9QD/qcc7d72W4c5WOMnYb5JazX1aVTocKaioz39jZsDCkvqFQSVJ2mp nNNG+7q7GcGz3knRNy/VJvAXYTY5KCo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1707745013; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pPBDHwov/gQzCIoZmZGL09sU8rD42LII0klGZX2DBs8=; b=qFV69bHkkD/7LaWIw+RoePpPdtW9M5FzUZkBBFpsI44TBaTESfWf8CSApVT4KnSqpNRUDs Bv6OM4whbE13UPAQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1707745013; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pPBDHwov/gQzCIoZmZGL09sU8rD42LII0klGZX2DBs8=; b=pUnNIzx3Y5f1W1b9ql2I8z4pk+qOL87fj8tb/ItN8TF8D1sV4XqA3HnIUfEdsBtgCSzwXs Mrf8i6Po0Xr4QZQ9QD/qcc7d72W4c5WOMnYb5JazX1aVTocKaioz39jZsDCkvqFQSVJ2mp nNNG+7q7GcGz3knRNy/VJvAXYTY5KCo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1707745013; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pPBDHwov/gQzCIoZmZGL09sU8rD42LII0klGZX2DBs8=; b=qFV69bHkkD/7LaWIw+RoePpPdtW9M5FzUZkBBFpsI44TBaTESfWf8CSApVT4KnSqpNRUDs Bv6OM4whbE13UPAQ== Received: by hawking.nue2.suse.org (Postfix, from userid 17005) id AF6CE4A03A6; Mon, 12 Feb 2024 14:36:53 +0100 (CET) From: Andreas Schwab To: Adhemerval Zanella via Glibc-cvs Cc: Adhemerval Zanella Subject: Re: [glibc/release/2.34/master] elf: Fix wrong break removal from 8ee878592c In-Reply-To: <20240212132237.2AB663858D32@sourceware.org> (Adhemerval Zanella via Glibc-cvs's message of "Mon, 12 Feb 2024 13:22:37 +0000 (GMT)") References: <20240212132237.2AB663858D32@sourceware.org> X-Yow: Now I'm being INVOLUNTARILY shuffled closer to the CLAM DIP with the BROKEN PLASTIC FORKS in it!! Date: Mon, 12 Feb 2024 14:36:53 +0100 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain Authentication-Results: smtp-out1.suse.de; none X-Spam-Level: X-Spam-Score: -1.11 X-Spamd-Result: default: False [-1.11 / 50.00]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; NEURAL_SPAM_SHORT(2.98)[0.993]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; TO_DN_ALL(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:email,linaro.org:email]; FUZZY_BLOCKED(0.00)[rspamd.com]; RCVD_COUNT_ZERO(0.00)[0]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; MID_RHS_MATCH_FROM(0.00)[]; BAYES_HAM(-2.99)[99.95%] X-Spam-Status: No, score=-9.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Feb 12 2024, Adhemerval Zanella via Glibc-cvs wrote: > https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=62ac4b09c4ee66c91478212359b8ac44b4f6a9e2 > > commit 62ac4b09c4ee66c91478212359b8ac44b4f6a9e2 > Author: Adhemerval Zanella > Date: Thu Dec 7 11:17:35 2023 -0300 > > elf: Fix wrong break removal from 8ee878592c > > Reported-by: Alexander Monakov > (cherry picked from commit 546a1ba664626603660b595662249d524e429013) > > Diff: > --- > elf/readelflib.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/elf/readelflib.c b/elf/readelflib.c > index c09425a574..2c0bae9fc0 100644 > --- a/elf/readelflib.c > +++ b/elf/readelflib.c > @@ -112,6 +112,7 @@ process_elf_file (const char *file_name, const char *lib, int *flag, > case PT_INTERP: > program_interpreter = (char *) (file_contents + segment->p_offset); > check_ptr (program_interpreter); > + break; > > /* Check if this is enough to classify the binary. */ > for (j = 0; j < sizeof (interpreters) / sizeof (interpreters [0]); This needs to be reverted, 2.34 does *not* have 8ee878592c. -- Andreas Schwab, SUSE Labs, schwab@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different."