From mboxrd@z Thu Jan 1 00:00:00 1970 From: pdm@sourceware.cygnus.com To: gnats-cvs@sourceware.cygnus.com Subject: gnats/gnats pr-edit.c internal.c index.c edit. ... Date: Fri, 09 Nov 2001 14:22:00 -0000 Message-id: <20011109222210.6962.qmail@sourceware.cygnus.com> X-SW-Source: 2001/msg00323.html List-Id: CVSROOT: /cvs/gnats Module name: gnats Changes by: pdm@sources.redhat.com 2001-11-09 14:22:10 Modified files: gnats : pr-edit.c internal.c index.c edit.c edit-pr.sh cmds.c Log message: * pr-edit.c (main): Don't test a "boolean" int value by comparing it with 1. * index.c (getFirstPR): Always checkPRChain; this decreases the chances of writing out stale index data. (writeIndex): Check to make sure that index hasn't changed since last read, fail with CODE_INVALID_INDEX if it has. Also generate email to admin about the problem. Update indexDesc->mtime after writing out new index. * cmds.c (GNATS_appnOrRepl): Lock database before editing. * pr-edit.c (main): Lock database before --append or --replace in non-network mode. * edit.c (lock_pr): Quash a race bug in PR locking. Use basically the same code as in lock_gnats. Report lock time if PR is locked. * internal.c (lock_gnats): Changed from using creat(path, 0) to atomic open() to eliminate a race in database lock creation. * internal.c (punt): Complain to stderr if database is null. queue-pr sometimes calls punt() before defining database, and this way cron will report the error. * edit-pr.sh (lock): Report pid when locking PR. (submit): If there are errors during submission, prompt the user to abort or retry. Patches: http://sources.redhat.com/cgi-bin/cvsweb.cgi/gnats/gnats/pr-edit.c.diff?cvsroot=gnats&r1=1.33&r2=1.34 http://sources.redhat.com/cgi-bin/cvsweb.cgi/gnats/gnats/internal.c.diff?cvsroot=gnats&r1=1.27&r2=1.28 http://sources.redhat.com/cgi-bin/cvsweb.cgi/gnats/gnats/index.c.diff?cvsroot=gnats&r1=1.38&r2=1.39 http://sources.redhat.com/cgi-bin/cvsweb.cgi/gnats/gnats/edit.c.diff?cvsroot=gnats&r1=1.53&r2=1.54 http://sources.redhat.com/cgi-bin/cvsweb.cgi/gnats/gnats/edit-pr.sh.diff?cvsroot=gnats&r1=1.13&r2=1.14 http://sources.redhat.com/cgi-bin/cvsweb.cgi/gnats/gnats/cmds.c.diff?cvsroot=gnats&r1=1.62&r2=1.63