From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27502 invoked from network); 7 Apr 2004 18:51:14 -0000 Received: from unknown (HELO monty-python.gnu.org) (199.232.76.173) by sources.redhat.com with SMTP; 7 Apr 2004 18:51:14 -0000 Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.30) id 1BBI3Z-0004qW-CG for listarch-gnats-devel@sources.redhat.com; Wed, 07 Apr 2004 14:45:49 -0400 Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.30) id 1BBI3H-0004py-KO for help-gnats@gnu.org; Wed, 07 Apr 2004 14:45:31 -0400 Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.30) id 1BBI2k-0004hl-Oa for help-gnats@gnu.org; Wed, 07 Apr 2004 14:45:30 -0400 Received: from [63.70.210.58] (helo=mms1.broadcom.com) by monty-python.gnu.org with esmtp (Exim 4.30) id 1BBI2k-0004hH-4W; Wed, 07 Apr 2004 14:44:58 -0400 Received: from 63.70.210.1 by mms1.broadcom.com with ESMTP (Broadcom SMTP Relay (MMS v5.6.0)); Wed, 07 Apr 2004 11:44:56 -0700 X-Server-Uuid: 97B92932-364A-4474-92D6-5CFE9C59AD14 Received: from LTIRVAJIMS3 (dhcp-10-3-136-44.broadcom.com [10.3.136.44]) by mon-irva-11.broadcom.com (8.9.1/8.9.1) with ESMTP id LAA14916; Wed, 7 Apr 2004 11:43:59 -0700 (PDT) From: "Jim Searle" To: bug-gnats@gnu.org Date: Wed, 07 Apr 2004 18:51:00 -0000 Organization: Broadcom Corporation Message-ID: <029301c41cd0$5a6dff30$2c88030a@LTIRVAJIMS3> MIME-Version: 1.0 X-Priority: 3 (Normal) X-MSMail-Priority: Normal X-Mailer: Microsoft Outlook, Build 10.0.4510 X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2800.1165 In-Reply-To: <026e01c41cc9$7db896f0$2c88030a@LTIRVAJIMS3> Importance: Normal X-WSS-ID: 6C6A93A21P8379803-01-01 Content-Type: multipart/mixed; boundary="----=_NextPart_000_0294_01C41C95.AE0F2730" Cc: help-gnats@gnu.org Subject: RE: gnatsd Too many open files error X-BeenThere: help-gnats@gnu.org X-Mailman-Version: 2.1.4 Precedence: list Reply-To: jims@broadcom.com List-Id: General discussion about GNU GNATS List-Archive: List-Post: List-Help: List-Subscribe: , Sender: help-gnats-bounces+listarch-gnats-devel=sources.redhat.com@gnu.org Errors-To: help-gnats-bounces+listarch-gnats-devel=sources.redhat.com@gnu.org X-SW-Source: 2004-q2/txt/msg00022.txt.bz2 This is a multi-part message in MIME format. ------=_NextPart_000_0294_01C41C95.AE0F2730 Content-Type: multipart/alternative; boundary="----=_NextPart_001_0295_01C41C95.AE0F2730" Content-Transfer-Encoding: 7bit ------=_NextPart_001_0295_01C41C95.AE0F2730 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Content-length: 2405 The attached patch fixes my problem. -----Original Message----- From: bug-gnats-bounces+jims=3Dbroadcom.com@gnu.org [mailto:bug-gnats-bounces+jims=3Dbroadcom.com@gnu.org] On Behalf Of Jim Sea= rle Sent: Wednesday, April 07, 2004 10:55 AM To: bug-gnats@gnu.org Cc: help-gnats@gnu.org Subject: RE: gnatsd Too many open files error I CC'ed hep-gnats since I've received no response from bug-gnats... =20 It seems that gnatsd never closes the PR.lock file, an strace of the REPL command shows this: open("/tools/gnats/4.0/etc/gnats/db-vlsibcmx/gnats-adm/gnats.lock", O_WRONLY|O_CREAT|O_TRUNC|O_EXCL, 0) =3D 5 open("/tools/gnats/4.0/etc/gnats/db-vlsibcmx/gnats-adm/index", O_RDONLY) = =3D 6 close(6) =3D 0 open("/tools/gnats/4.0/etc/gnats/db-vlsibcmx/gnats-adm/locks/3515.lock", O_WRONLY|O_CREAT|O_TRUNC|O_EXCL, 0644) =3D 6 close(6) =3D 0 open("/tools/gnats/4.0/etc/gnats/db-vlsibcmx/test/3515", O_RDONLY) =3D 6 close(6) =3D 0 open("/tools/gnats/4.0/etc/gnats/db-vlsibcmx/test/3515", O_RDONLY) =3D 6 close(6) =3D 0 open("/tools/gnats/4.0/etc/gnats/db-vlsibcmx/test/3515", O_RDONLY) =3D 6 close(6) =3D 0 open("/tools/gnats/4.0/etc/gnats/db-vlsibcmx/test/3515", O_RDWR|O_CREAT|O_TRUNC, 0666) =3D 6 close(6) =3D 0 unlink("/tools/gnats/4.0/etc/gnats/db-vlsibcmx/test/3515.old") =3D 0 open("/tools/gnats/4.0/etc/gnats/db-vlsibcmx/gnats-adm/indI6fqXL", O_RDWR|O_CREAT|O_EXCL, 0600) =3D 6 close(6) =3D 0 unlink("/tools/gnats/4.0/etc/gnats/db-vlsibcmx/gnats-adm/locks/3515.lock") = =3D 0 unlink("/tools/gnats/4.0/etc/gnats/db-vlsibcmx/gnats-adm/gnats.lock") =3D 0 -----Original Message----- From: bug-gnats-bounces+jims=3Dbroadcom.com@gnu.org [mailto:bug-gnats-bounces+jims=3Dbroadcom.com@gnu.org] On Behalf Of Jim Sea= rle Sent: Tuesday, April 06, 2004 3:23 PM To: bug-gnats@gnu.org Subject: gnatsd Too many open files error If during a single gnatsd session I modify a field for a bunch of PR's, on change number 252 I get this error: =20 640 Cannot create lock file /tools/gnats/4.0/etc/gnats/db-vlsibcmx/gnats-adm/locks/1579.lock: Too many open files =20 My simple command file is: CHDB someDB someUser thePassword REPL 1579 Priority low =2E with the last 3 lines repeated 252 times. =20 ------=_NextPart_001_0295_01C41C95.AE0F2730 Content-Type: text/html; charset=us-ascii Content-Transfer-Encoding: quoted-printable Content-length: 6008 Message
The=20 attached patch fixes my problem.
-----Original Message-----
From:=20 bug-gnats-bounces+jims=3Dbroadcom.com@gnu.org=20 [mailto:bug-gnats-bounces+jims=3Dbroadcom.com@gnu.org] On Behalf Of Jim=20 Searle
Sent: Wednesday, April 07, 2004 10:55 AM
To:=20 bug-gnats@gnu.org
Cc: help-gnats@gnu.org
Subject: RE:= =20 gnatsd Too many open files error

I=20 CC'ed hep-gnats since I've received no response from=20 bug-gnats...
 
It=20 seems that gnatsd never closes the PR.lock file, an strace of the REPL co= mmand=20 shows this:
open("/tools/gnats/4.0/etc/gnats/db-vlsibcmx/g= nats-adm/gnats.lock",=20 O_WRONLY|O_CREAT|O_TRUNC|O_EXCL, 0) =3D=20 5
open("/tools/gnats/4.0/etc/gnats/db-vlsibcmx/gnats-adm/index", O_RDO= NLY)=20 =3D=20 6
close(6)          =             &nb= sp;        =20 =3D=20 0
open("/tools/gnats/4.0/etc/gnats/db-vlsibcmx/gnats-adm/locks/3515.lo= ck",=20 O_WRONLY|O_CREAT|O_TRUNC|O_EXCL, 0644) =3D=20 6
close(6)          =             &nb= sp;        =20 =3D 0
open("/tools/gnats/4.0/etc/gnats/db-vlsibcmx/test/3515", O_RDONL= Y) =3D=20 6
close(6)          =             &nb= sp;        =20 =3D 0
open("/tools/gnats/4.0/etc/gnats/db-vlsibcmx/test/3515", O_RDONL= Y) =3D=20 6
close(6)          =             &nb= sp;        =20 =3D 0
open("/tools/gnats/4.0/etc/gnats/db-vlsibcmx/test/3515", O_RDONL= Y) =3D=20 6
close(6)          =             &nb= sp;        =20 =3D 0
open("/tools/gnats/4.0/etc/gnats/db-vlsibcmx/test/3515",=20 O_RDWR|O_CREAT|O_TRUNC, 0666) =3D=20 6
close(6)          =             &nb= sp;        =20 =3D 0
unlink("/tools/gnats/4.0/etc/gnats/db-vlsibcmx/test/3515.old") = =3D=20 0
open("/tools/gnats/4.0/etc/gnats/db-vlsibcmx/gnats-adm/indI6fqXL",=20 O_RDWR|O_CREAT|O_EXCL, 0600) =3D=20 6
close(6)          =             &nb= sp;        =20 =3D=20 0
unlink("/tools/gnats/4.0/etc/gnats/db-vlsibcmx/gnats-adm/locks/3515.= lock")=20 =3D 0
unlink("/tools/gnats/4.0/etc/gnats/db-vlsibcmx/gnats-adm/gnats.l= ock") =3D=20 0
<= FONT=20 face=3DTahoma size=3D2>-----Original Message-----
From:=20 bug-gnats-bounces+jims=3Dbroadcom.com@gnu.org=20 [mailto:bug-gnats-bounces+jims=3Dbroadcom.com@gnu.org] On Behalf Of = Jim=20 Searle
Sent: Tuesday, April 06, 2004 3:23 PM
To:=20 bug-gnats@gnu.org
Subject: gnatsd Too many open files=20 error

If du= ring a=20 single gnatsd session I modify a field for a bunch of PR's, on change n= umber=20 252 I get this error:
 
640 Cannot create lock file=20 /tools/gnats/4.0/etc/gnats/db-vlsibcmx/gnats-adm/locks/1579.lock: Too m= any=20 open files
 
My si= mple=20 command file is:
CHDB = someDB=20 someUser thePassword
REPL 1579=20 Priority
low
.
with = the last 3=20 lines repeated 252 times.
 
------=_NextPart_001_0295_01C41C95.AE0F2730-- ------=_NextPart_000_0294_01C41C95.AE0F2730 Content-Type: application/octet-stream; name=patch_internal_1 Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename=patch_internal_1 Content-length: 1388 *** internal.c Wed Apr 7 11:11:13 2004=0A= --- ../../gnats-4.0-Linux/gnats/internal.c Wed Nov 5 20:04:08 2003=0A= ***************=0A= *** 117,126 ****=0A= lock_gnats (const DatabaseInfo database, ErrorDesc *err)=0A= {=0A= char *path;=0A= ! int count, res, fdes;=0A= const int MAXWAIT =3D 10;=0A= const int GRANULARITY =3D 1;=0A= !=20=20=20=0A= path =3D gnats_adm_dir (database, "gnats.lock");=0A= =20=20=0A= =20=20=0A= --- 117,126 ----=0A= lock_gnats (const DatabaseInfo database, ErrorDesc *err)=0A= {=0A= char *path;=0A= ! int count, res;=0A= const int MAXWAIT =3D 10;=0A= const int GRANULARITY =3D 1;=0A= !=20=0A= path =3D gnats_adm_dir (database, "gnats.lock");=0A= =20=20=0A= =20=20=0A= ***************=0A= *** 129,139 ****=0A= {=0A= errno =3D 0;=0A= /* use atomic create, to avoid races */=0A= ! fdes =3D open (path, O_CREAT | O_TRUNC | O_WRONLY | O_EXCL, 0);=0A= ! if (fdes !=3D -1)=0A= {=0A= /* success */=0A= - close(fdes);=0A= break;=0A= }=0A= else=0A= --- 129,137 ----=0A= {=0A= errno =3D 0;=0A= /* use atomic create, to avoid races */=0A= ! if (open (path, O_CREAT | O_TRUNC | O_WRONLY | O_EXCL, 0) !=3D -1)= =0A= {=0A= /* success */=0A= break;=0A= }=0A= else=0A= ------=_NextPart_000_0294_01C41C95.AE0F2730 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline Content-length: 139 _______________________________________________ Help-gnats mailing list Help-gnats@gnu.org http://mail.gnu.org/mailman/listinfo/help-gnats ------=_NextPart_000_0294_01C41C95.AE0F2730--