From: Gerald Pfeifer <pfeifer@dbai.tuwien.ac.at>
To: gcc-patches@gcc.gnu.org
Cc: help-gnats@gnu.org
Subject: PATCH: gnatsweb.pl
Date: Tue, 18 Dec 2001 13:32:00 -0000 [thread overview]
Message-ID: <Pine.BSF.4.43.0112182214090.45594-100000@pulcherrima.dbai.tuwien.ac.at> (raw)
Message-ID: <20011218133200.abIb19RiqdQk8fE2x7sVy6PGHbl7IsM_DRYd9RoQaQo@z> (raw)
GCC folks, I installed this so that our gnatsweb 2.9.3 installation works
both with and without style sheets supported/enabled.
GNATS folks (Yngve): Without this patch, gnatsweb mixes classic HTML color
tags and CSS with the result that (for example on Netscape 4.7) users with
style sheets disabled easily get white text on white background.
The first patch is for gnatsweb 2.9.3 and tested, the second for current
development sources 2.99.2 and untested. (If you agree, would you mind
applying the one against 2.9.3 for me? I can take care of 2.99.2.)
Gerald
2001-12-18 Gerald Pfeifer <pfeifer@dbai.tuwien.ac.at>
* gnatsweb.pl (page_start_html): Do not mix classic HTML color
tags (BGCOLOR) and CSS.
Index: gnatsweb.pl
===================================================================
RCS file: /cvs/gcc/wwwdocs/cgi-bin/gnatsweb.pl,v
retrieving revision 1.45
retrieving revision 1.49
diff -u -3 -p -r1.45 -r1.49
--- gnatsweb.pl 2001/12/15 09:57:40 1.45
+++ gnatsweb.pl 2001/12/18 21:11:00 1.49
@@ -2501,7 +2501,7 @@ EOF
$createurl = get_createpr_url(0,1);
$row = qq(<TR>\n<TD><TABLE BORDER="0" CELLSPACING="0" CELLPADDING="3" WIDTH="100%">);
- $row .= qq(<TR BGCOLOR="$site_banner_background">\n<TD ALIGN="LEFT">);
+ $row .= qq(<TR STYLE="background-color: $site_banner_background">\n<TD ALIGN="LEFT">);
$row .= qq(<SPAN STYLE="$bannerstyle $banner_fontsize1">$global_prefs{'database'} </SPAN>)
if $global_prefs{'database'};
$row .= qq(<SPAN STYLE="$bannerstyle $banner_fontsize2">User: $db_prefs{'user'} </SPAN>)
Index: gnatsweb.pl
===================================================================
RCS file: /cvsroot/gnatsweb/gnatsweb/gnatsweb.pl,v
retrieving revision 1.87
diff -u -3 -p -r1.87 gnatsweb.pl
--- gnatsweb.pl 12 Dec 2001 14:10:56 -0000 1.87
+++ gnatsweb.pl 18 Dec 2001 21:20:30 -0000
@@ -3077,7 +3077,7 @@ EOF
my $createurl = get_pr_url('create', 0, 1);
$row = qq(<tr>\n<td><table border="0" cellspacing="0" cellpadding="3" width="100%">);
- $row .= qq(<tr bgcolor="$site_banner_background">\n<td align="left">);
+ $row .= qq(<tr style="background-color: $site_banner_background">\n<td align="left">);
$row .= qq(<span style="$bannerstyle $banner_fontsize1">$global_prefs{'database'} </span>)
if $global_prefs{'database'};
$row .= qq(<span style="$bannerstyle $banner_fontsize2">User: $db_prefs{'user'} </span>)
_______________________________________________
Help-gnats mailing list
Help-gnats@gnu.org
http://mail.gnu.org/mailman/listinfo/help-gnats
next reply other threads:[~2001-12-18 13:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-11-14 16:27 Gerald Pfeifer [this message]
2001-12-18 13:32 ` Gerald Pfeifer
2002-01-06 8:53 ` Gerald Pfeifer
-- strict thread matches above, loose matches on Subject: below --
2001-01-10 16:58 Gerald Pfeifer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.BSF.4.43.0112182214090.45594-100000@pulcherrima.dbai.tuwien.ac.at \
--to=pfeifer@dbai.tuwien.ac.at \
--cc=gcc-patches@gcc.gnu.org \
--cc=help-gnats@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).