From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9735 invoked from network); 25 Sep 2002 18:18:14 -0000 Received: from unknown (HELO monty-python.gnu.org) (199.232.76.173) by sources.redhat.com with SMTP; 25 Sep 2002 18:18:14 -0000 Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.10) id 17uGjc-0004KJ-00; Wed, 25 Sep 2002 14:18:04 -0400 Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.10) id 17uGiW-0003W5-00 for help-gnats@gnu.org; Wed, 25 Sep 2002 14:16:56 -0400 Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.10) id 17uGiT-0003TH-00 for help-gnats@gnu.org; Wed, 25 Sep 2002 14:16:55 -0400 Received: from cluster2.netman.dk ([193.88.72.48]) by monty-python.gnu.org with esmtp (Exim 4.10) id 17uGiS-0003S3-00 for help-gnats@gnu.org; Wed, 25 Sep 2002 14:16:53 -0400 Received: (from lh@localhost) by cluster2.netman.dk (8.11.4/8.11.4) id g8PIEEf1156092; Wed, 25 Sep 2002 20:14:14 +0200 (MEST) From: Lars Henriksen To: Yngve Svendsen Cc: Robert Lupton the Good , help-gnats@gnu.org Subject: Re: Patch for gnatsweb.pl Message-ID: <20020925181413.GA1154909@cluster2.netman.dk> References: <20020922184733.GA1071317@cluster2.netman.dk> <15749.57217.976539.558063@wire7.Princeton.EDU> <20020922184733.GA1071317@cluster2.netman.dk> <5.1.0.14.2.20020925174747.044096d0@romulus.holland.sun.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5.1.0.14.2.20020925174747.044096d0@romulus.holland.sun.com> User-Agent: Mutt/1.4i Sender: help-gnats-admin@gnu.org Errors-To: help-gnats-admin@gnu.org X-BeenThere: help-gnats@gnu.org X-Mailman-Version: 2.0.11 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: General discussion about GNU GNATS List-Archive: Date: Wed, 25 Sep 2002 13:13:00 -0000 X-SW-Source: 2002-q3/txt/msg00127.txt.bz2 On Wed, Sep 25, 2002 at 05:59:53PM +0200, Yngve Svendsen wrote: > At 17:39 25.09.2002 +0200, Lars Henriksen wrote: > >Do we want to (must we) keep backward combatibility? With gnatsweb 3.*? > >With earlier gnatsweb 4 versions? As far as I can see from some bookmarks > >produced by 3.113, compatibility with that version is already broken > >(I have seen some "arrivedbefore=" or "modifiedafter=" query parameters > >that are not recognised by gnatsweb 4). Oops, got my version numbers mixed up here. Of course I meant gnatsweb 2.* (not 3.*) and 2.9.* (not 3.113). > While working with the recent "Sort By" patches, I had occasion to look > more closely at this. Compatibility with stored Gnatsweb 2 queries is a > non-issue I think. There are a few sites I know of that use Gnatsweb 3.99.x > in production (Dirk, this probably concerns you), but if we are ever to rid > Gnatsweb of this totally unnecessary level of complexity, this is the time. Agreed. We use gnatsweb 3.99.3 (+patches) here, but until now it has supported gnatsweb 2 queries--which I didn't realise until they stopped working. I thought for a while that it would be possible to get rid of field2param() entirely, isolate paramfield() to two or three places (where query parameters are read) and keep backward compatibility. But I don't any longer. The convoluted logic of submitquery() lives by the fact that query_page() sets upper case query parameters while advanced_query_page() sets lower case ones. > I think I'll use my Supreme Maintainer Authority to decree that field2param > and param2field must die. Fine. That implies that the query expression logic in submitquery() must be corrected since it depends on case differences. > Relevant patches are very welcome, since I have somewhat limited time to > code right now I'll try my hand at some. Lars Henriksen _______________________________________________ Help-gnats mailing list Help-gnats@gnu.org http://mail.gnu.org/mailman/listinfo/help-gnats