From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12826 invoked from network); 31 Oct 2002 20:50:10 -0000 Received: from unknown (HELO monty-python.gnu.org) (199.232.76.173) by sources.redhat.com with SMTP; 31 Oct 2002 20:50:10 -0000 Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.10) id 187MDZ-0001Ao-00; Thu, 31 Oct 2002 15:47:06 -0500 Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.10) id 187Lxx-0004qd-00 for help-gnats@gnu.org; Thu, 31 Oct 2002 15:30:57 -0500 Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.10) id 187Lxu-0004qN-00 for help-gnats@gnu.org; Thu, 31 Oct 2002 15:30:56 -0500 Received: from cluster1.netman.dk ([193.88.72.47]) by monty-python.gnu.org with esmtp (Exim 4.10) id 187Lxt-0004oK-00 for help-gnats@gnu.org; Thu, 31 Oct 2002 15:30:54 -0500 Received: (from lh@localhost) by cluster1.netman.dk (8.11.4/8.11.4) id g9VKTRp849606; Thu, 31 Oct 2002 21:29:27 +0100 (MET) From: Lars Henriksen To: Yngve Svendsen Cc: Dieperink Alwin , "'help-gnats@gnu.org'" Subject: Re: Removed lines in responsible Message-ID: <20021031202927.GA834415@cluster1.netman.dk> References: <5.1.0.14.2.20021014210535.04654818@ms-etro01-01.norway> <5.1.0.14.2.20021014210535.04654818@ms-etro01-01.norway> <5.2.0.5.0.20021027224006.049630a0@ms-etro01-01.norway.sun.com> <20021028083728.GA708614@cluster1.netman.dk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20021028083728.GA708614@cluster1.netman.dk> User-Agent: Mutt/1.4i Sender: help-gnats-admin@gnu.org Errors-To: help-gnats-admin@gnu.org X-BeenThere: help-gnats@gnu.org X-Mailman-Version: 2.0.11 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: General discussion about GNU GNATS List-Archive: Date: Thu, 31 Oct 2002 12:50:00 -0000 X-SW-Source: 2002-q4/txt/msg00032.txt.bz2 On Mon, Oct 28, 2002 at 09:37:28AM +0100, Lars Henriksen wrote: > On Sun, Oct 27, 2002 at 10:48:14PM +0100, Yngve Svendsen wrote: > > At 13:25 24.10.2002 +0200, Lars Henriksen wrote: > > ... > > Committed. there were some problems with hash references, but I cleaned it > > up. > > Oops. Sorry about that. Some of my local changes crept in here. I have found > that with many categories and many responsibles, it's nice to have the menues > alphabetically sorted (as they were in gnatsweb 2.9.3). I have been planning > to submit a patch so here it comes (see below). Unfortunately I managed to mess up my own changes so the patch mentioned above wasn't quite correct. I you want alphabetically sorted Category and Responsible menues (like in gnatsweb 2.9.3) here is the patch. Lars Henriksen Index: gnatsweb.pl =================================================================== RCS file: /cvsroot/gnatsweb/gnatsweb/gnatsweb.pl,v retrieving revision 1.115 diff -u -r1.115 gnatsweb.pl --- gnatsweb.pl 27 Oct 2002 22:33:18 -0000 1.115 +++ gnatsweb.pl 31 Oct 2002 20:25:59 -0000 @@ -1063,7 +1063,11 @@ # Get default value(s). my $default = fieldinfo($_, 'default'); - my $values = fieldinfo($_, 'values'); + my @values = @{fieldinfo($_, 'values')}; + if ($_ eq $CATEGORY_FIELD || $_ eq $SUBMITTER_ID_FIELD) + { + @values = sort {lc($a) cmp lc($b)} @values; + } # The "intro" provides a way for the site callback to print something # at the top of a given field. @@ -1081,16 +1085,16 @@ # Force user to choose a category. if ($_ eq $CATEGORY_FIELD) { - push(@$values, "unknown") if (!grep /^unknown$/, @$values); + push(@values, "unknown") if (!grep /^unknown$/, @values); $default = "unknown"; } - print popup_or_scrolling_menu($_, $values, $default), + print popup_or_scrolling_menu($_, \@values, $default), "\n\n"; } elsif (fieldinfo ($_, 'fieldtype') eq 'multienum') { my $defaultsref = parse_multienum($default, $_); - print multiselect_menu($_, $values, $defaultsref), + print multiselect_menu($_, \@values, $defaultsref), "\n\n"; } elsif (fieldinfo($_, 'fieldtype') eq "multitext") @@ -1563,7 +1567,12 @@ $field_number++; - my $values = fieldinfo($_, 'values'); + my @values = @{fieldinfo ($_, 'values')}; + if ($_ eq $CATEGORY_FIELD || + $_ eq $SUBMITTER_ID_FIELD || + $_ eq $RESPONSIBLE_FIELD) { + @values = sort {lc($a) cmp lc($b)} @values; + } # The "intro" provides a way for the site callback to print something # at the top of a given field. @@ -1576,18 +1585,18 @@ { my $default = $fields{$_}; # Check whether field value is a known enumeration value. - if (!(grep /^$default$/, @$values)) + if (!(grep /^$default$/, @values)) { - push(@$values, 'unknown') if (!grep /^unknown$/, @$values); + push(@values, 'unknown') if (!grep /^unknown$/, @values); $default = 'unknown'; } - print popup_or_scrolling_menu($_, $values, $default), + print popup_or_scrolling_menu($_, \@values, $default), "\n\n"; } elsif (fieldinfo ($_, 'fieldtype') eq 'multienum') { my $defaultsref = parse_multienum($fields{$_}, $_); - print multiselect_menu($_, $values, $defaultsref), + print multiselect_menu($_, \@values, $defaultsref), "\n\n"; } elsif (fieldinfo ($_, 'fieldtype') eq 'multitext') @@ -1867,8 +1876,12 @@ if (fieldinfo($_, 'fieldtype') =~ /enum/) { print "$_:\n"; - my $value_list=fieldinfo($_, 'values'); - my @values=('any', @$value_list); + my @values = @{fieldinfo($_, 'values')}; + if ($_ eq $RESPONSIBLE_FIELD || $_ eq $CATEGORY_FIELD) + { + @values=sort {lc($a) cmp lc($b)} @values; + } + @values=('any', @values); if (fieldinfo($_, 'fieldtype') eq 'enum') { print popup_or_scrolling_menu ($_, \@values, $values[0]); @@ -2054,11 +2067,15 @@ print ""; if (fieldinfo($_, 'fieldtype') =~ 'enum') { - my $ary_ref = fieldinfo($_, 'values'); - my $size = scalar(@$ary_ref); + my @values = @{fieldinfo($_, 'values')}; + if ($_ eq $RESPONSIBLE_FIELD || $_ eq $CATEGORY_FIELD) + { + @values = sort {lc($a) cmp lc($b)} @values; + } + my $size = @values; $size = 4 if $size > 4; print $q->scrolling_list(-name=>$_, - -values=>$ary_ref, + -values=>\@values, -multiple=>1, -size=>$size); } _______________________________________________ Help-gnats mailing list Help-gnats@gnu.org http://mail.gnu.org/mailman/listinfo/help-gnats From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12858 invoked from network); 31 Oct 2002 20:50:10 -0000 Received: from unknown (HELO monty-python.gnu.org) (199.232.76.173) by sources.redhat.com with SMTP; 31 Oct 2002 20:50:10 -0000 Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.10) id 187MFd-0001iD-00; Thu, 31 Oct 2002 15:49:13 -0500 Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.10) id 187M1y-0005pH-00 for help-gnats@gnu.org; Thu, 31 Oct 2002 15:35:06 -0500 Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.10) id 187Lz7-0005Db-00 for help-gnats@gnu.org; Thu, 31 Oct 2002 15:32:13 -0500 Received: from cluster1.netman.dk ([193.88.72.47]) by monty-python.gnu.org with esmtp (Exim 4.10) id 187Lz6-0005Ck-00 for help-gnats@gnu.org; Thu, 31 Oct 2002 15:32:08 -0500 Received: (from lh@localhost) by cluster1.netman.dk (8.11.4/8.11.4) id g9VKTRp849606; Thu, 31 Oct 2002 21:29:27 +0100 (MET) From: Lars Henriksen To: Yngve Svendsen Cc: Dieperink Alwin , "'help-gnats@gnu.org'" Subject: Re: Removed lines in responsible Message-ID: <20021031202927.GA834415@cluster1.netman.dk> References: <5.1.0.14.2.20021014210535.04654818@ms-etro01-01.norway> <5.1.0.14.2.20021014210535.04654818@ms-etro01-01.norway> <5.2.0.5.0.20021027224006.049630a0@ms-etro01-01.norway.sun.com> <20021028083728.GA708614@cluster1.netman.dk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20021028083728.GA708614@cluster1.netman.dk> User-Agent: Mutt/1.4i Sender: help-gnats-admin@gnu.org Errors-To: help-gnats-admin@gnu.org X-BeenThere: help-gnats@gnu.org X-Mailman-Version: 2.0.11 Precedence: bulk List-Help: List-Post: List-Subscribe: , List-Id: General discussion about GNU GNATS List-Archive: Date: Thu, 31 Oct 2002 15:34:00 -0000 X-SW-Source: 2002-q4/txt/msg00033.txt.bz2 Message-ID: <20021031153400.2BLYlIjU3dEAsa2xGqbZm-Q2N0n9rGP7Oqe8UXPIg2I@z> On Mon, Oct 28, 2002 at 09:37:28AM +0100, Lars Henriksen wrote: > On Sun, Oct 27, 2002 at 10:48:14PM +0100, Yngve Svendsen wrote: > > At 13:25 24.10.2002 +0200, Lars Henriksen wrote: > > ... > > Committed. there were some problems with hash references, but I cleaned it > > up. > > Oops. Sorry about that. Some of my local changes crept in here. I have found > that with many categories and many responsibles, it's nice to have the menues > alphabetically sorted (as they were in gnatsweb 2.9.3). I have been planning > to submit a patch so here it comes (see below). Unfortunately I managed to mess up my own changes so the patch mentioned above wasn't quite correct. I you want alphabetically sorted Category and Responsible menues (like in gnatsweb 2.9.3) here is the patch. Lars Henriksen Index: gnatsweb.pl =================================================================== RCS file: /cvsroot/gnatsweb/gnatsweb/gnatsweb.pl,v retrieving revision 1.115 diff -u -r1.115 gnatsweb.pl --- gnatsweb.pl 27 Oct 2002 22:33:18 -0000 1.115 +++ gnatsweb.pl 31 Oct 2002 20:25:59 -0000 @@ -1063,7 +1063,11 @@ # Get default value(s). my $default = fieldinfo($_, 'default'); - my $values = fieldinfo($_, 'values'); + my @values = @{fieldinfo($_, 'values')}; + if ($_ eq $CATEGORY_FIELD || $_ eq $SUBMITTER_ID_FIELD) + { + @values = sort {lc($a) cmp lc($b)} @values; + } # The "intro" provides a way for the site callback to print something # at the top of a given field. @@ -1081,16 +1085,16 @@ # Force user to choose a category. if ($_ eq $CATEGORY_FIELD) { - push(@$values, "unknown") if (!grep /^unknown$/, @$values); + push(@values, "unknown") if (!grep /^unknown$/, @values); $default = "unknown"; } - print popup_or_scrolling_menu($_, $values, $default), + print popup_or_scrolling_menu($_, \@values, $default), "\n\n"; } elsif (fieldinfo ($_, 'fieldtype') eq 'multienum') { my $defaultsref = parse_multienum($default, $_); - print multiselect_menu($_, $values, $defaultsref), + print multiselect_menu($_, \@values, $defaultsref), "\n\n"; } elsif (fieldinfo($_, 'fieldtype') eq "multitext") @@ -1563,7 +1567,12 @@ $field_number++; - my $values = fieldinfo($_, 'values'); + my @values = @{fieldinfo ($_, 'values')}; + if ($_ eq $CATEGORY_FIELD || + $_ eq $SUBMITTER_ID_FIELD || + $_ eq $RESPONSIBLE_FIELD) { + @values = sort {lc($a) cmp lc($b)} @values; + } # The "intro" provides a way for the site callback to print something # at the top of a given field. @@ -1576,18 +1585,18 @@ { my $default = $fields{$_}; # Check whether field value is a known enumeration value. - if (!(grep /^$default$/, @$values)) + if (!(grep /^$default$/, @values)) { - push(@$values, 'unknown') if (!grep /^unknown$/, @$values); + push(@values, 'unknown') if (!grep /^unknown$/, @values); $default = 'unknown'; } - print popup_or_scrolling_menu($_, $values, $default), + print popup_or_scrolling_menu($_, \@values, $default), "\n\n"; } elsif (fieldinfo ($_, 'fieldtype') eq 'multienum') { my $defaultsref = parse_multienum($fields{$_}, $_); - print multiselect_menu($_, $values, $defaultsref), + print multiselect_menu($_, \@values, $defaultsref), "\n\n"; } elsif (fieldinfo ($_, 'fieldtype') eq 'multitext') @@ -1867,8 +1876,12 @@ if (fieldinfo($_, 'fieldtype') =~ /enum/) { print "$_:\n"; - my $value_list=fieldinfo($_, 'values'); - my @values=('any', @$value_list); + my @values = @{fieldinfo($_, 'values')}; + if ($_ eq $RESPONSIBLE_FIELD || $_ eq $CATEGORY_FIELD) + { + @values=sort {lc($a) cmp lc($b)} @values; + } + @values=('any', @values); if (fieldinfo($_, 'fieldtype') eq 'enum') { print popup_or_scrolling_menu ($_, \@values, $values[0]); @@ -2054,11 +2067,15 @@ print ""; if (fieldinfo($_, 'fieldtype') =~ 'enum') { - my $ary_ref = fieldinfo($_, 'values'); - my $size = scalar(@$ary_ref); + my @values = @{fieldinfo($_, 'values')}; + if ($_ eq $RESPONSIBLE_FIELD || $_ eq $CATEGORY_FIELD) + { + @values = sort {lc($a) cmp lc($b)} @values; + } + my $size = @values; $size = 4 if $size > 4; print $q->scrolling_list(-name=>$_, - -values=>$ary_ref, + -values=>\@values, -multiple=>1, -size=>$size); } _______________________________________________ Help-gnats mailing list Help-gnats@gnu.org http://mail.gnu.org/mailman/listinfo/help-gnats