public inbox for
 help / color / mirror / Atom feed
From: Chad Walstrom <>
Subject: [PATCH] don't know how to make gnats-pwconv.o
Date: Tue, 30 Nov 2004 07:00:00 -0000	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

[-- Attachment #1.1: Type: text/plain, Size: 2165 bytes --]

Tim Buck wrote:
> autoheader: `' is updated
> Then I did:
> # autoconf
> # cd ..
> # make clean && ./configure --prefix=/usr/gnats
> When configure was done, I did 'make', and now I'm back to:
> Creating gnats-databases...
> make: don't know how to make gnats-pwconv.o. Stop
> *** Error code 2

Hmm...  Is there any way to get a little more verbosity in your make

I did some digging.  It looks like the HAVE_CRYPT definition is never
really set.  I don't know when it ever was. HAVE_CRYPT_H is being set in (including the older 2.13 generated version).  We need to
check for this new define in gnats-pwconv.c and gnatsd.c.  Apparently,
as the comment states, crypt() can be defined in unistd.h or crypt.h.
We need to figure out which, and handle it appropriately.

Additionally, gnats-pwconv.c has extraneous #include directives that are
already called in gnats.h.  This may actually be one source of confusion
by the compiler/linker.

I haven't yet tested this thoroughly, but here's a possible patch to
actually include the crypt.h header file correctly.  Preliminary tests
on my machine are favorable, but then again, I didn't have problems
w/the Debian GNU/Linux setup.

--- orig/gnats/gnats-pwconv.c
+++ mod/gnats/gnats-pwconv.c
@@ -19,15 +19,10 @@
 #include "gnats.h"
-#ifdef HAVE_CRYPT		/* some systems declare `crypt' in unistd.h */
+#ifdef HAVE_CRYPT_H		/* some systems declare `crypt' in unistd.h */
 #include <crypt.h>
-#include <getopt.h>
-#include <stdio.h>
-#include <time.h>
-#include <unistd.h>
 enum _Crypt_Type { NONE, PLAIN, CRYPT, MD5 };
 typedef enum _Crypt_Type Crypt_Type;
--- orig/gnats/gnatsd.c
+++ mod/gnats/gnatsd.c
@@ -24,7 +24,7 @@
 #include "query.h"
-#ifdef HAVE_CRYPT		/* some systems declare `crypt' in unistd.h */
+#ifdef HAVE_CRYPT_H		/* some systems declare `crypt' in unistd.h */
 #include <crypt.h>

Chad Walstrom <> 
           assert(expired(knowledge)); /* core dump */

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

[-- Attachment #2: Type: text/plain, Size: 140 bytes --]

Help-gnats mailing list

           reply	other threads:[~2004-11-30  7:00 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).