From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8248 invoked from network); 30 Nov 2004 07:00:29 -0000 Received: from unknown (HELO lists.gnu.org) (199.232.76.165) by sourceware.org with SMTP; 30 Nov 2004 07:00:29 -0000 Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1CZ29O-0000S6-DH for listarch-gnats-devel@sources.redhat.com; Tue, 30 Nov 2004 02:10:14 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1CZ299-0000RZ-CX for help-gnats@gnu.org; Tue, 30 Nov 2004 02:09:59 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1CZ298-0000RA-Km for help-gnats@gnu.org; Tue, 30 Nov 2004 02:09:58 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1CZ298-0000R7-I0 for help-gnats@gnu.org; Tue, 30 Nov 2004 02:09:58 -0500 Received: from [199.199.210.160] (helo=chef.nerp.net) by monty-python.gnu.org with esmtp (Exim 4.34) id 1CZ1zY-0008Vz-IY for help-gnats@gnu.org; Tue, 30 Nov 2004 02:00:04 -0500 Received: from skuld.wookimus.net (c-66-41-156-164.mn.client2.attbi.com [66.41.156.164]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by chef.nerp.net (Postfix) with ESMTP id DC2DE3A931; Tue, 30 Nov 2004 01:00:02 -0600 (CST) Received: by skuld.wookimus.net (Postfix, from userid 1000) id 43D121D03; Tue, 30 Nov 2004 00:59:17 -0600 (CST) Date: Tue, 30 Nov 2004 07:00:00 -0000 From: Chad Walstrom To: help-gnats@gnu.org Message-ID: <20041130065917.GA23753@wookimus.net> Mail-Followup-To: help-gnats@gnu.org, Tim Buck References: <419CACFF.7000303@sun.com> <1075D35F-3978-11D9-9658-000393C83AC4@rrinc.com> <20041118180434.GA23848@wookimus.net> <20041118184751.GB23848@wookimus.net> <20041118190204.GC23848@wookimus.net> Mime-Version: 1.0 In-Reply-To: X-Operating-System: Linux skuld 2.6.8-1-k7 X-GnuPG-Fingerprint: B4AB D627 9CBD 687E 7A31 1950 0CC7 0B18 206C 5AFD User-Agent: Mutt/1.5.6+20040722i Cc: Subject: [PATCH] don't know how to make gnats-pwconv.o X-BeenThere: help-gnats@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: General discussion about GNU GNATS List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============0120857585==" Sender: help-gnats-bounces+listarch-gnats-devel=sources.redhat.com@gnu.org Errors-To: help-gnats-bounces+listarch-gnats-devel=sources.redhat.com@gnu.org X-SW-Source: 2004-q4/txt/msg00027.txt.bz2 --===============0120857585== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="SLDf9lqlvOQaIe6s" Content-Disposition: inline --SLDf9lqlvOQaIe6s Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-length: 2114 Tim Buck wrote: > autoheader: `autoconf.h.in' is updated >=20 > Then I did: > # autoconf > # cd .. > # make clean && ./configure --prefix=3D/usr/gnats >=20 > When configure was done, I did 'make', and now I'm back to: >=20 > Creating gnats-databases... > make: don't know how to make gnats-pwconv.o. Stop > *** Error code 2 Hmm... Is there any way to get a little more verbosity in your make process? I did some digging. It looks like the HAVE_CRYPT definition is never really set. I don't know when it ever was. HAVE_CRYPT_H is being set in autoconf.h.in (including the older 2.13 generated version). We need to check for this new define in gnats-pwconv.c and gnatsd.c. Apparently, as the comment states, crypt() can be defined in unistd.h or crypt.h. We need to figure out which, and handle it appropriately. Additionally, gnats-pwconv.c has extraneous #include directives that are already called in gnats.h. This may actually be one source of confusion by the compiler/linker. I haven't yet tested this thoroughly, but here's a possible patch to actually include the crypt.h header file correctly. Preliminary tests on my machine are favorable, but then again, I didn't have problems w/the Debian GNU/Linux setup. --- orig/gnats/gnats-pwconv.c +++ mod/gnats/gnats-pwconv.c @@ -19,15 +19,10 @@ =20 #include "gnats.h" #ifdef HAVE_LIBCRYPT -#ifdef HAVE_CRYPT /* some systems declare `crypt' in unistd.h */ +#ifdef HAVE_CRYPT_H /* some systems declare `crypt' in unistd.h */ #include #endif #endif -#include -#include -#include -#include - =20 enum _Crypt_Type { NONE, PLAIN, CRYPT, MD5 }; typedef enum _Crypt_Type Crypt_Type; --- orig/gnats/gnatsd.c +++ mod/gnats/gnatsd.c @@ -24,7 +24,7 @@ #include "query.h" =20 #ifdef HAVE_LIBCRYPT -#ifdef HAVE_CRYPT /* some systems declare `crypt' in unistd.h */ +#ifdef HAVE_CRYPT_H /* some systems declare `crypt' in unistd.h */ #include #endif #endif --=20 Chad Walstrom http://www.wookimus.net/ assert(expired(knowledge)); /* core dump */ --SLDf9lqlvOQaIe6s Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-Disposition: inline Content-length: 189 -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.4 (GNU/Linux) iD8DBQFBrBpFDMcLGCBsWv0RAh/JAKCBVHFIFpIGM5eVB39dqFf2kye6GwCfZKEx 8sBG5i76K81AGTZ82I/jM84= =JvUf -----END PGP SIGNATURE----- --SLDf9lqlvOQaIe6s-- --===============0120857585== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline Content-length: 140 _______________________________________________ Help-gnats mailing list Help-gnats@gnu.org http://lists.gnu.org/mailman/listinfo/help-gnats --===============0120857585==--