From: Mel Hatzis <hatzis@juniper.net>
To: Milan Zamazal <pdm@zamazal.org>
Cc: Lars Henriksen <Lars.Henriksen@netman.dk>, help-gnats@gnu.org
Subject: Re: 4.0 beta - question on parsing of subject line in PR header
Date: Wed, 15 May 2002 16:21:00 -0000 [thread overview]
Message-ID: <3CE2ECEF.5040508@juniper.net> (raw)
In-Reply-To: <3CE2C3BF.1060906@juniper.net>
Mel Hatzis wrote:
> Milan Zamazal wrote:
>
>>>>>>> "MH" == Mel Hatzis <hatzis@juniper.net> writes:
>>>>>>>
>>
>> MH> After understanding this a little more, we determined that there
>> MH> was definitely a bug here. The regular expression used is
>> MH> incorrect ...for one, it requires a '\<' as the start of the
>> MH> subject line in order to match. It is also missing an escape
>> MH> character before the '|' and is incorrectly anchored to the
>> MH> beginning of the subject line.
>>
>> MH> I have attached a patch.
>> Thank you, Mel, for the patch. Before I apply it, I'd like to clarify
>> one little thing: Do you know why `\\<' didn't work? It should mean
>> "beginning of a word", should it be notated in a different way (other
>> than the one you've used)?
>>
>
> Milan, I was incorrect regarding the use of '\\<'...it does work.
> You can change the pattern match to the following:
>
> "(.*[^\\<])?\\<((PR[ \t/])\\|([-a-z0-9_+.]+/))([0-9]+)"
>
> I tested this and it works. I guess this is what was originally intended.
>
Thinking about this some more, it would be *really* useful to allow this
regular expression to be overriden in the dbconfig file. Allowing user's
to define their own would provide them the flexibility to get as fancy
as they want with some of the corner cases where the default regex behaviour
is not desirable...such as "Re: PR 50 (was PR 33)" which matches PR 33.
Thoughts?
--
Mel Hatzis
Juniper Networks, Inc.
_______________________________________________
Help-gnats mailing list
Help-gnats@gnu.org
http://mail.gnu.org/mailman/listinfo/help-gnats
next prev parent reply other threads:[~2002-05-15 23:21 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-05-10 16:21 Mel Hatzis
2002-05-11 4:21 ` Lars Henriksen
2002-05-11 10:46 ` Mel Hatzis
2002-05-15 10:00 ` Milan Zamazal
2002-05-15 13:25 ` Mel Hatzis
2002-05-15 16:21 ` Mel Hatzis [this message]
2002-05-16 1:00 ` Yngve Svendsen
2002-05-16 16:27 ` Milan Zamazal
2002-05-23 11:42 ` Mel Hatzis
2002-05-26 8:37 ` Milan Zamazal
2002-05-16 16:27 ` Milan Zamazal
2002-05-17 7:24 ` Chad Walstrom
2002-05-19 13:40 ` Milan Zamazal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3CE2ECEF.5040508@juniper.net \
--to=hatzis@juniper.net \
--cc=Lars.Henriksen@netman.dk \
--cc=help-gnats@gnu.org \
--cc=pdm@zamazal.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).