From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4087 invoked from network); 8 Dec 2002 20:27:59 -0000 Received: from unknown (HELO monty-python.gnu.org) (199.232.76.173) by sources.redhat.com with SMTP; 8 Dec 2002 20:27:59 -0000 Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.10.13) id 18L7v7-00034B-03 for listarch-gnats-devel@sources.redhat.com; Sun, 08 Dec 2002 15:20:57 -0500 Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.10.13) id 18L7uV-0002px-00 for help-gnats@gnu.org; Sun, 08 Dec 2002 15:20:19 -0500 Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.10.13) id 18L7uQ-0002oX-00 for help-gnats@gnu.org; Sun, 08 Dec 2002 15:20:17 -0500 Received: from natint.juniper.net ([207.17.136.129] helo=merlot.juniper.net) by monty-python.gnu.org with esmtp (Exim 4.10.13) id 18L7uP-0002nL-00; Sun, 08 Dec 2002 15:20:13 -0500 Received: from juniper.net (ssh.juniper.net [207.17.136.39]) by merlot.juniper.net (8.11.3/8.11.3) with ESMTP id gB8KKBS65895; Sun, 8 Dec 2002 12:20:11 -0800 (PST) (envelope-from hatzis@juniper.net) Message-ID: <3DF3A833.3060508@juniper.net> Date: Sun, 08 Dec 2002 23:11:00 -0000 From: Mel Hatzis User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.0.0) Gecko/20020529 X-Accept-Language: en-us, en MIME-Version: 1.0 To: "Andrew J. Gray" References: <200212021037.gB2Ab8D04083@localhost.localdomain> <3DEBE798.4030702@juniper.net> <200212080625.gB86Pvh07876@localhost.localdomain> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit cc: help-gnats@gnu.org Subject: Re: patch to display new PR number for new submissions X-BeenThere: help-gnats@gnu.org X-Mailman-Version: 2.1b5 Precedence: list Reply-To: hatzis@juniper.net List-Id: General discussion about GNU GNATS List-Help: List-Post: List-Subscribe: , List-Archive: Sender: help-gnats-bounces+listarch-gnats-devel=sources.redhat.com@gnu.org Errors-To: help-gnats-bounces+listarch-gnats-devel=sources.redhat.com@gnu.org X-SW-Source: 2002-q4/txt/msg00083.txt.bz2 On 12/07/2002 10:25 PM, Andrew J. Gray submitted: >>Now that 4.0 beta2 is out the door please review >>(and hopefully accept) the following patch which >>allows send-pr and "pr-edit --submit" to display >>newly created PR numbers. >> >> > >Thanks for submitting that patch, I have had a look at it. > >I have a concern that the changes it makes to the gnatsd command >protocol break the assumption that clients should not attempt to parse >the message strings on response lines from the server. > >As I understand it the current protocol for submitting PRs goes >something like: > >-> SUBM ><- 211 Ok. >-> >-> >-> . ><- 210 PR Added. > >(-> is from the client, <- is from the server) >With your changes the response from the server would be, for example: > ><- 210 PR 68 Added. > >I was thinking that it would be more consistent to have the server >return: > ><- 351-The added PR number is: ><- 350 68 > >What do you think? Can you see problems with implementing the "return >PR number to submitter" functionality in the way I am suggesting? > > I see no problems with your suggested approach. >I try to code modifications to your patch along these lines. > > > OK great....thanks for looking at the patch. -- Mel Hatzis _______________________________________________ Help-gnats mailing list Help-gnats@gnu.org http://mail.gnu.org/mailman/listinfo/help-gnats