From: Mel Hatzis <hatzis@juniper.net>
To: "Andrew J. Gray" <andrewg@gnu.org>
Cc: help-gnats@gnu.org
Subject: Re: patch to display new PR number for new submissions
Date: Mon, 03 Feb 2003 20:46:00 -0000 [thread overview]
Message-ID: <3E3ED43B.4020305@juniper.net> (raw)
In-Reply-To: <200302020832.h128Wef03254@localhost.localdomain>
On 02/02/2003 12:32 AM, Andrew J. Gray wrote:
>>>>Now that 4.0 beta2 is out the door please review
>>>>(and hopefully accept) the following patch which
>>>>allows send-pr and "pr-edit --submit" to display
>>>>newly created PR numbers.
>>>
>>>I try to code modifications to your patch along these lines.
>>
>
> I have coded modifications to your patch along the lines I
> suggested. The modified patch is at the end of this message. Please
> have a look at it and let me know (a) if it meets the requirements you
> were addressing with the original patch, and (b) if there are any
> problems with it.
Generally, the patch looks good...it's a cleaner approach to the
one I submitted.
One small concern with the patch though...in get_reply you've made
a change allowing for outfp to be NULL...
> RCS file: /cvsroot/gnats/gnats/gnats/client.c,v
> retrieving revision 1.46
> diff -u -p -r1.46 client.c
> --- gnats/client.c 25 Nov 2002 13:58:33 -0000 1.46
> +++ gnats/client.c 2 Feb 2003 08:31:23 -0000
> @@ -334,7 +334,8 @@ get_reply (FILE *outfp)
> break;
>
> case CODE_INFORMATION:
> - fprintf (outfp, "%s\n", r->text);
> + if (outfp != NULL)
> + fprintf (outfp, "%s\n", r->text);
> break;
>
> case CODE_NONEXISTENT_PR:
> @@ -1216,7 +1217,7 @@ netSetEditEmailAddr (const char *addr)
> }
However, immediately above this code, there's another reference to
'outfp' which is unprotected....
else
{
read_server (outfp);
}
I suggest that you put some checks for NULL around this too.
The only other comment I have is that there's a small typo in the docs:
> -the database. A zero exit code is returned if the submission was
> -successful. Otherwise, the reason(s) for the PR being rejected are
> -printed to stdout, and a non-zero exit code is returned.
> +the database. If the submission a zero exit code is returned.
^^^^^^
I think you're missing 'is successful' in the above sentence.
> Otherwise, the
> +reason(s) for the PR being rejected are
> +printed, and a non-zero exit code is returned.
> +
> +@item --show-prnum
>
> Since this change is an enhancement and modifies the gnatsd command
> protocol I am thinking it should not be included in GNATS 4.0 final,
> but put on a 4.1 branch. What do people think?
I'm in favour of rolling out 4.0 pretty soon....if you think putting
this patch on a 4.1 branch would help this endevour, I'd suggest
you do just that.
--
Mel Hatzis
_______________________________________________
Help-gnats mailing list
Help-gnats@gnu.org
http://mail.gnu.org/mailman/listinfo/help-gnats
next prev parent reply other threads:[~2003-02-03 20:46 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-12-02 15:08 GNU GNATS 4.0 beta2 released Andrew J. Gray
2002-12-02 15:11 ` compiling gnats 4.0 beta 2 Steve Friedman
2002-12-04 2:36 ` Andrew J. Gray
2002-12-03 19:52 ` patch to display new PR number for new submissions Mel Hatzis
2002-12-04 3:02 ` Andrew J. Gray
2002-12-08 7:58 ` Andrew J. Gray
2002-12-08 12:27 ` Yngve Svendsen
2002-12-08 23:11 ` Patching the manual Lars Henriksen
2002-12-12 3:58 ` Yngve Svendsen
2002-12-12 6:29 ` patch to display new PR number for new submissions Andrew J. Gray
2002-12-08 23:11 ` Mel Hatzis
2003-02-02 9:32 ` Andrew J. Gray
2003-02-03 20:46 ` Mel Hatzis [this message]
2003-02-03 20:51 ` Yngve Svendsen
2003-02-03 21:17 ` Mel Hatzis
2003-02-03 22:10 ` Yngve Svendsen
2003-02-09 8:28 ` Andrew J. Gray
2003-02-09 7:48 ` Andrew J. Gray
2003-04-29 20:24 ` Yngve Svendsen
2002-12-09 10:54 ` dirk bergstrom
2002-12-14 14:26 ` Andrew J. Gray
2003-08-30 11:58 ` Andrew J. Gray
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3E3ED43B.4020305@juniper.net \
--to=hatzis@juniper.net \
--cc=andrewg@gnu.org \
--cc=help-gnats@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).