From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18944 invoked from network); 9 Mar 2003 04:42:40 -0000 Received: from unknown (HELO monty-python.gnu.org) (199.232.76.173) by 172.16.49.205 with SMTP; 9 Mar 2003 04:42:40 -0000 Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.10.13) id 18rsdm-0004p0-08 for listarch-gnats-devel@sources.redhat.com; Sat, 08 Mar 2003 23:42:26 -0500 Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.10.13) id 18rsdT-0004kd-00 for help-gnats@gnu.org; Sat, 08 Mar 2003 23:42:07 -0500 Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.10.13) id 18rsdQ-0004d7-00 for help-gnats@gnu.org; Sat, 08 Mar 2003 23:42:06 -0500 Received: from natint.juniper.net ([207.17.136.129] helo=merlot.juniper.net) by monty-python.gnu.org with esmtp (Exim 4.10.13) id 18rsdQ-0004c9-00 for help-gnats@gnu.org; Sat, 08 Mar 2003 23:42:04 -0500 Received: from juniper.net (ssh.juniper.net [207.17.136.39]) by merlot.juniper.net (8.11.3/8.11.3) with ESMTP id h294g1S91952; Sat, 8 Mar 2003 20:42:01 -0800 (PST) (envelope-from hatzis@juniper.net) Message-ID: <3E6AC502.409@juniper.net> Date: Sun, 09 Mar 2003 04:42:00 -0000 From: Mel Hatzis User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.2.1) Gecko/20021130 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Yngve Svendsen Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit cc: "'help-gnats@gnu.org'" Subject: patch for missing 'chek' prior to edit X-BeenThere: help-gnats@gnu.org X-Mailman-Version: 2.1b5 Precedence: list List-Id: General discussion about GNU GNATS List-Help: List-Post: List-Subscribe: , List-Archive: Sender: help-gnats-bounces+listarch-gnats-devel=sources.redhat.com@gnu.org Errors-To: help-gnats-bounces+listarch-gnats-devel=sources.redhat.com@gnu.org X-SW-Source: 2003-q1/txt/msg00091.txt.bz2 Please review the following patch which fixes a bug whereby a 'chek' is not performed when submitting an edited PR. I noticed that 'chek initial' is done for submitnewpr but there's no 'chek' for submitedit. This means that field validation based on the the field definitions in the dbconfig is not performed for PR edits. Here's the patch... Index: gnatsweb.pl =================================================================== RCS file: /cvsroot/gnatsweb/gnatsweb/gnatsweb.pl,v retrieving revision 1.120 diff -u -p -r1.120 gnatsweb.pl --- gnatsweb.pl 8 Jan 2003 13:04:17 -0000 1.120 +++ gnatsweb.pl 9 Mar 2003 04:37:01 -0000 @@ -1808,6 +1808,10 @@ sub submitedit # Submit the edits. We need to unlock the PR even if the edit fails local($suppress_client_exit) = 1; + client_cmd("chek"); + last LOCKED if ($client_would_have_exited); + client_cmd("$newpr\n."); + last LOCKED if ($client_would_have_exited); client_cmd("editaddr $db_prefs{'user'}"); last LOCKED if ($client_would_have_exited); client_cmd("edit $pr"); -- Mel Hatzis _______________________________________________ Help-gnats mailing list Help-gnats@gnu.org http://mail.gnu.org/mailman/listinfo/help-gnats