From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14683 invoked from network); 11 Oct 2003 01:51:54 -0000 Received: from unknown (HELO monty-python.gnu.org) (199.232.76.173) by sources.redhat.com with SMTP; 11 Oct 2003 01:51:54 -0000 Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.24) id 1A88tq-0000T5-AJ for listarch-gnats-devel@sources.redhat.com; Fri, 10 Oct 2003 21:50:30 -0400 Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24) id 1A88th-0000QQ-87 for help-gnats@gnu.org; Fri, 10 Oct 2003 21:50:21 -0400 Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24) id 1A88tB-0008T0-9h for help-gnats@gnu.org; Fri, 10 Oct 2003 21:50:20 -0400 Received: from [207.17.136.150] (helo=merlot.juniper.net) by monty-python.gnu.org with esmtp (TLSv1:DES-CBC3-SHA:168) (Exim 4.24) id 1A88tA-0008Ri-PK for help-gnats@gnu.org; Fri, 10 Oct 2003 21:49:48 -0400 Received: from juniper.net (snowy.juniper.net [172.17.13.16]) by merlot.juniper.net (8.11.3/8.11.3) with ESMTP id h9B1nlj35806 for ; Fri, 10 Oct 2003 18:49:47 -0700 (PDT) (envelope-from hatzis@juniper.net) Message-ID: <3F8761BB.3080202@juniper.net> Date: Sat, 11 Oct 2003 01:51:00 -0000 From: Mel Hatzis User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030624 X-Accept-Language: en-us, en MIME-Version: 1.0 To: help-gnats@gnu.org Content-Type: multipart/mixed; boundary="------------030706030804090903020700" Subject: enhancement to the emacs "query-pr" command X-BeenThere: help-gnats@gnu.org X-Mailman-Version: 2.1.2 Precedence: list List-Id: General discussion about GNU GNATS List-Archive: List-Post: List-Help: List-Subscribe: , Sender: help-gnats-bounces+listarch-gnats-devel=sources.redhat.com@gnu.org Errors-To: help-gnats-bounces+listarch-gnats-devel=sources.redhat.com@gnu.org X-SW-Source: 2003-q4/txt/msg00007.txt.bz2 This is a multi-part message in MIME format. --------------030706030804090903020700 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Content-length: 327 A colleague at work came up with an enhancement to gnats.el so that query-pr will accept both space separated PR numbers as well as GNATS query expressions as input. Please review (and hopefully accept) the attached patch which, IMO, makes the 'query-pr' command in emacs mode more intuitive and easier to use. -- Mel Hatzis --------------030706030804090903020700 Content-Type: text/plain; name="gnats.el.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="gnats.el.patch" Content-length: 945 Change Log: 2003-10-10 Mark D Baushke * gnats.el (gnats-do-query): Accept a list of PR numbers as an alternative to just a gnats query expression. --- gnats.el~ Fri Oct 10 13:55:33 2003 +++ gnats.el Fri Oct 10 14:55:34 2003 @@ -1592,9 +1592,15 @@ The function works in the query buffers. ;; TODO: Handle gnatsd errors. (gnats-send-command "QFMT" "summary") (gnats-send-command "RSET") - (unless (string= query "") - (gnats-send-command "EXPR" query)) - (let ((result (gnats-send-command "QUER"))) + (let* ((quer-cmd + (cond + ((string-match "^\[0-9 \]\+$" query) + (concat "QUER " query)) + (t + (unless (string= query "") + (gnats-send-command "EXPR" query)) + "QUER"))) + (result (gnats-send-command quer-cmd))) (unless (= (caar result) 300) (error "Query error (%d %s)" (car (car result)) (cadr (car result)))) (setq result (cdr result)) --------------030706030804090903020700 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline Content-length: 139 _______________________________________________ Help-gnats mailing list Help-gnats@gnu.org http://mail.gnu.org/mailman/listinfo/help-gnats --------------030706030804090903020700--