From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15255 invoked from network); 21 Apr 2005 23:52:22 -0000 Received: from unknown (HELO lists.gnu.org) (199.232.76.165) by sourceware.org with SMTP; 21 Apr 2005 23:52:22 -0000 Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DOlTT-0005JL-SP for listarch-gnats-devel@sources.redhat.com; Thu, 21 Apr 2005 19:52:47 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1DOlSQ-0004Hy-KT for help-gnats@gnu.org; Thu, 21 Apr 2005 19:51:42 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1DOlSO-0004Ha-Ec for help-gnats@gnu.org; Thu, 21 Apr 2005 19:51:41 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DOlSO-0003ZO-AH for help-gnats@gnu.org; Thu, 21 Apr 2005 19:51:40 -0400 Received: from [216.27.182.174] (helo=wattes.org) by monty-python.gnu.org with esmtp (Exim 4.34) id 1DOlPv-0002QG-Rl for help-gnats@gnu.org; Thu, 21 Apr 2005 19:49:08 -0400 Received: from [10.64.209.22] ([10.64.209.22]) by wattes.org (8.11.6/8.11.6) with ESMTP id j3LNkEA18155; Thu, 21 Apr 2005 16:46:15 -0700 Message-ID: <42683B4A.6090101@wattes.org> Date: Thu, 21 Apr 2005 23:52:00 -0000 From: Mel Hatzis User-Agent: Mozilla Thunderbird 1.0.2 (Macintosh/20050317) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Chad Walstrom References: <42645A54.5040007@wattes.org> In-Reply-To: <42645A54.5040007@wattes.org> X-Enigmail-Version: 0.89.5.0 X-Enigmail-Supports: pgp-inline, pgp-mime Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: help-gnats@gnu.org Subject: Re: patch #2 - towards a generic backend datastore X-BeenThere: help-gnats@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: General discussion about GNU GNATS List-Archive: List-Post: List-Help: List-Subscribe: , Sender: help-gnats-bounces+listarch-gnats-devel=sources.redhat.com@gnu.org Errors-To: help-gnats-bounces+listarch-gnats-devel=sources.redhat.com@gnu.org X-SW-Source: 2005-q2/txt/msg00014.txt.bz2 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 I have done some additional testing with my proposed patch and everything appears to be in order. *I plan on committing these changes to the mainline tomorrow.* Note that there is a minor change introduced with this patch. If the index is reloaded when gnatsd processes an 'rset' command, gnatsd currently generates the following message: 210 Reset state...reloaded the index. After this patch is committed, the following message will be issued (which is the same message that is generated currently, whenever the index is not reloaded): 210 Reset state. This change is required in order to make the client/server interaction datastore agnostic. Thankfully, the rset command was the only one which referred to the index - and thus needed to be modified. - -- Mel Hatzis Mel Hatzis wrote: > Please review the attached patch which contains a number of > modifications intended to restructure the code to support a > generalized backend datastore. > > This second patch is rather large - larger than I originally > planned. I expect that all subsequent patches will be > significantly smaller. > > The primary goal in this patch was to completely isolate the > index from the generic (i.e. non-datastore specific) GNATS > functionality and introduce a flat-file datastore library with > which all relevant binaries are linked. A small addition to > configure was made to build the flat-file datastore library > by default. > > This is a significant leap forward in generalizing the backend > datastore. The GNATS/datastore interface really starts to become > more obvious with this patch. > > I have attempted to adequately describe all changes in detail > in the ChangeLog. Feel free to ask me to elaborate where > necessary. > > Once again, I've run these changes through my regression test > suite and they appear to work well. Of course, I encourage > more testing if people have the bandwidth. > -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.2 (Darwin) Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org iD8DBQFCaDtKNF74HmYqaSERAqqaAJ4sKH+JurajgHwaTh6rJQDHx7yOZgCglfKh afJu2EuD78wcvn26kWb4hnA= =xffG -----END PGP SIGNATURE----- _______________________________________________ Help-gnats mailing list Help-gnats@gnu.org http://lists.gnu.org/mailman/listinfo/help-gnats