public inbox for gnats-devel@sourceware.org
 help / color / mirror / Atom feed
From: Yngve Svendsen <yngve.svendsen@clustra.com>
To: gnats-devel@sources.redhat.com
Subject: PATCH: Minor redirect fix for Gnatsweb 2.8.0
Date: Tue, 08 May 2001 06:15:00 -0000	[thread overview]
Message-ID: <5.1.0.14.2.20010508151227.00b8b338@iwww.clustra.com> (raw)

The following patch fixes a problem caused by a change of behaviour in all 
versions of CGI.pm from 2.64 onwards (2.753 is current right now). It now 
by default returns URLs with parameters separated by semicolons instead of 
ampersands, subtly breaking the redirect functionality of Gnatsweb versions 
2.7 beta and 2.8.0. Redirects still happen, but the browser is redirected 
to the main Gnatsweb page instead of to the page which the user came from.

The following patch fixes this, by instructing CGI.pm to use "old-style" URLs:

Index: gnatsweb.pl
===================================================================
RCS file: /clustra/cvs/gnatsweb2/gnatsweb.pl,v
retrieving revision 1.25
diff -u -p -r1.25 gnatsweb.pl
--- gnatsweb.pl 2001/05/04 13:44:12     1.25
+++ gnatsweb.pl 2001/05/08 13:09:11
@@ -97,9 +97,7 @@ else
  use CGI::Carp qw/fatalsToBrowser/;
  # 8/22/99 kenstir: CGI.pm-2.50's file upload is broken.
  # 9/19/99 kenstir: CGI.pm-2.55's file upload is broken.
-use CGI 2.56 qw/:standard/;
-#use CGI 2.56 ();
-#use CGI::Pretty qw/:standard/;
+use CGI 2.56 qw(-oldstyle_urls :all);
  use gnats qw/client_init client_exit client_cmd/;

  # Debugging fresh code.





Yngve Svendsen
IS Engineer
Clustra AS, Trondheim, Norway
yngve.svendsen@clustra.com

             reply	other threads:[~2001-05-08  6:15 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-05-08  6:15 Yngve Svendsen [this message]
2001-05-08  8:47 Dirk Bergstrom

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5.1.0.14.2.20010508151227.00b8b338@iwww.clustra.com \
    --to=yngve.svendsen@clustra.com \
    --cc=gnats-devel@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).