public inbox for gnats-devel@sourceware.org
 help / color / mirror / Atom feed
From: Yngve Svendsen <yngve.svendsen@clustra.com>
To: gnats-devel@sources.redhat.com
Cc: Milan Zamazal <pdm@zamazal.org>
Subject: PATCH: Errors from tr when invoking send-pr v4 on Solaris
Date: Sat, 12 May 2001 05:29:00 -0000	[thread overview]
Message-ID: <5.1.0.14.2.20010512142523.00b3f788@iwww.clustra.com> (raw)

In the current version 4 CVS, send-pr contains 'tr' expressions that need 
to be quoted in order to work on Solaris. The patch below replaces ][ with 
\]\[ in these expressions. This should have no adverse effects in OSes that 
don't need this quoting in their tr, such as Linux (I have tested this on a 
Linux box).

Yngve Svendsen


Patch against current version 4 CVS:

Index: send-pr.sh
===================================================================
RCS file: /cvs/gnats/gnats/send-pr/send-pr.sh,v
retrieving revision 1.16
diff -u -p -r1.16 send-pr.sh
--- send-pr.sh  2001/04/08 18:28:25     1.16
+++ send-pr.sh  2001/05/12 12:22:26
@@ -371,7 +371,7 @@ __EOF__
                         else
                                 desc="<${values} (one line)>";
                         fi
-                       dpat=`echo "$desc" | tr '][*+^$|\()&/' '............'`
+                       dpat=`echo "$desc" | tr '\]\[*+^$|\()&/' 
'............'`
                         echo "/^>${fieldname}:/ s/${dpat}//" >> $FIXFIL
                     fi
                     echo "${fmtname}${desc}" >> $file
@@ -382,7 +382,7 @@ __EOF__
                         desc="  $default_val";
                     else
                         desc="  <`${BINDIR}/query-pr --field-description 
$fieldname` (multiple lines)>";
-                       dpat=`echo "$desc" | tr '][*+^$|\()&/' '............'`
+                       dpat=`echo "$desc" | tr '\]\[*+^$|\()&/' 
'............'`
                         echo "s/^${dpat}//" >> $FIXFIL
                     fi
                     echo "${fmtname}" >> $file;
@@ -394,7 +394,7 @@ __EOF__
                         desc="${default_val}"
                     else
                         desc="<`${BINDIR}/query-pr --field-description 
$fieldname` (one line)>"
-                       dpat=`echo "$desc" | tr '][*+^$|\()&/' '............'`
+                       dpat=`echo "$desc" | tr '\]\[*+^$|\()&/' 
'............'`
                         echo "/^>${fieldname}:/ s/${dpat}//" >> $FIXFIL
                     fi
                     echo "${fmtname}${desc}" >> $file

             reply	other threads:[~2001-05-12  5:29 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-05-12  5:29 Yngve Svendsen [this message]
2001-05-27  8:44 ` Milan Zamazal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5.1.0.14.2.20010512142523.00b3f788@iwww.clustra.com \
    --to=yngve.svendsen@clustra.com \
    --cc=gnats-devel@sources.redhat.com \
    --cc=pdm@zamazal.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).