From: Yngve Svendsen <yngve.svendsen@clustra.com>
To: Milan Zamazal <pdm@zamazal.org>
Cc: gnats-devel@sources.redhat.com
Subject: Re: Current Gnats 4 CVS broken on Solaris
Date: Tue, 12 Jun 2001 13:23:00 -0000 [thread overview]
Message-ID: <5.1.0.14.2.20010612221913.00ba0828@10.10.1.1> (raw)
In-Reply-To: <5.0.0.25.2.20010612171703.04c66ec0@mail.trd.clustra.com>
At 17:19 12.06.2001 +0200, Yngve Svendsen wrote:
>At 17:15 10.06.2001 +0200, Milan Zamazal wrote:
>> >>>>> "YS" == Yngve Svendsen <yngve.svendsen@clustra.com> writes:
>>
>> YS> Sorry, but it seems the configure check for %z support isn't
>> YS> working right.
>>
>>You're right. strftime is going to become my nightmare. :-| I tried to
>>fix it and also added a patch by Carl enabling numeric time zones also
>>on systems not supporting `%z'. Please try whether it works or not.
>
>Unfortunately, the nightmare continues. "make all" results in the
>following on a Solaris 7 system:
[snip]
On some systems, Solaris among them, isdigit() requires an explicit cast to
int. The very simple patch below fixes the problem and makes the current
GNATS 4 compile on both Solaris and Linux.
I have compiled and done some testing, and as far as I can tell, all is now
well on systems that don't support %z.
- Yngve
Index: misc.c
===================================================================
RCS file: /cvs/gnats/gnats/gnats/misc.c,v
retrieving revision 1.28
diff -u -p -r1.28 misc.c
--- misc.c 2001/06/10 17:15:47 1.28
+++ misc.c 2001/06/12 20:21:01
@@ -567,7 +567,7 @@ gnats_strftime (char *s, size_t size, co
{
char buf[16];
strftime (buf, 16, "%z", brokentime);
- have_strftime_with_z = isdigit (buf[1]);
+ have_strftime_with_z = isdigit ((int) (buf[1]));
}
if (have_strftime_with_z)
next prev parent reply other threads:[~2001-06-12 13:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-05-10 16:37 Yngve Svendsen
2001-05-27 8:36 ` Milan Zamazal
2001-05-30 8:51 ` Yngve Svendsen
2001-06-10 10:26 ` Milan Zamazal
2001-06-12 8:21 ` Yngve Svendsen
2001-06-12 13:23 ` Yngve Svendsen [this message]
2001-06-13 10:33 ` Milan Zamazal
2002-09-12 15:07 ` Wrong dates in PRs if no %z support in strftime(3) Lars Henriksen
[not found] <991303419.19767.ezmlm@sources.redhat.com>
2001-06-02 9:33 ` Current Gnats 4 CVS broken on Solaris Carl E. Lindberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5.1.0.14.2.20010612221913.00ba0828@10.10.1.1 \
--to=yngve.svendsen@clustra.com \
--cc=gnats-devel@sources.redhat.com \
--cc=pdm@zamazal.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).