public inbox for gnats-devel@sourceware.org
 help / color / mirror / Atom feed
From: Yngve Svendsen <yngve.svendsen@sun.com>
To: Lars Henriksen <Lars.Henriksen@netman.dk>,
	Robert Lupton the Good <rhl@astro.Princeton.EDU>
Cc: help-gnats@gnu.org
Subject: Re: Patch for gnatsweb.pl
Date: Wed, 25 Sep 2002 11:43:00 -0000	[thread overview]
Message-ID: <5.1.0.14.2.20020925174747.044096d0@romulus.holland.sun.com> (raw)
In-Reply-To: <20020925153941.GD1135030@cluster2.netman.dk>

At 17:39 25.09.2002 +0200, Lars Henriksen wrote:
>I've realised that there is even more to it than I thought at first.
>
>Robert Lupton's patch as well as mine breaks backward compatibility:
>bookmarked and stored queries may stop working or behave differently.
>
>According to comments in the gnatsweb code, that is also what has kept
>the parameter/field/lower/upper case confusion from being dealt with and
>field2param() and param2field() from disappearing. I have spent some
>time on figuring out the use of (dbconfig) field names versus form
>parameter (lower case) versions. It is not too difficult to eliminate
>the parameter/field conversion entirely and use dbconfig names (I have
>a patch) but again, not without breaking some existing bookmarked and
>stored queries.
>
>Do we want to (must we) keep backward combatibility? With gnatsweb 3.*?
>With earlier gnatsweb 4 versions? As far as I can see from some bookmarks
>produced by 3.113, compatibility with that version is already broken
>(I have seen some "arrivedbefore=" or "modifiedafter=" query parameters
>that are not recognised by gnatsweb 4).

While working with the recent "Sort By" patches, I had occasion to look 
more closely at this. Compatibility with stored Gnatsweb 2 queries is a 
non-issue I think. There are a few sites I know of that use Gnatsweb 3.99.x 
in production (Dirk, this probably concerns you), but if we are ever to rid 
Gnatsweb of this totally unnecessary level of complexity, this is the time.

I think I'll use my Supreme Maintainer Authority to decree that field2param 
and param2field must die. A first step has been to use the dbconfig field 
names in the Query Page fields instead of built-in/lowercase names.

Relevant patches are very welcome, since I have somewhat limited time to 
code right now (With Milan out of the picture I'd also like to keep half an 
eye on GNATS itself and apply those simple uncontroversial patches that are 
submitted from time to time)

- Yngve



_______________________________________________
Help-gnats mailing list
Help-gnats@gnu.org
http://mail.gnu.org/mailman/listinfo/help-gnats

  reply	other threads:[~2002-09-25 15:59 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-09-16  6:48 Robert Lupton the Good
2002-09-17  9:47 ` Yngve Svendsen
2002-09-23 12:22 ` Lars Henriksen
2002-09-25 11:18   ` Lars Henriksen
2002-09-25 11:43     ` Yngve Svendsen [this message]
2002-09-25 13:13       ` Lars Henriksen
2002-09-26 15:46         ` Robert Lupton the Good
2002-09-27  0:32         ` Robert Lupton the Good
2002-09-30  2:07         ` Lars Henriksen
     [not found] <20020915103254.22538.88942.Mailman@monty-python.gnu.org>
2002-09-16  6:56 ` Robert Lupton the Good
2002-09-16  7:24 ` patch " Robert Lupton the Good
2002-09-16  7:45 ` Robert Lupton the Good
  -- strict thread matches above, loose matches on Subject: below --
2002-09-16  6:46 Patch " Robert Lupton the Good
2001-09-06 14:09 patch " David, Lysander

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5.1.0.14.2.20020925174747.044096d0@romulus.holland.sun.com \
    --to=yngve.svendsen@sun.com \
    --cc=Lars.Henriksen@netman.dk \
    --cc=help-gnats@gnu.org \
    --cc=rhl@astro.Princeton.EDU \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).